From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Erik Schilling" <erik.schilling@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Gerd Hoffmann" <kraxel@redhat.com>,
virtio-fs@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH v2 04/13] include/hw/virtio: document virtio_notify_config
Date: Tue, 23 May 2023 16:40:24 -0400 [thread overview]
Message-ID: <20230523204024.GC140337@fedora> (raw)
In-Reply-To: <20230418162140.373219-5-alex.bennee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Tue, Apr 18, 2023 at 05:21:31PM +0100, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> include/hw/virtio/virtio.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index f236e94ca6..22ec098462 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -274,6 +274,13 @@ extern const VMStateInfo virtio_vmstate_info;
>
> int virtio_load(VirtIODevice *vdev, QEMUFile *f, int version_id);
>
> +/**
> + * virtio_notify_config() - signal a change to device config
> + * @vdev: the virtio device
The spec calls this sending a Configuration Change Notification
(https://docs.oasis-open.org/virtio/virtio/v1.2/csd01/virtio-v1.2-csd01.html#x1-1110001).
I suggest using VIRTIO specification terminology, otherwise every person
paraphrases the spec and you have to guess how QEMU code/comments map to
the spec.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-23 20:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 16:21 [PATCH v2 00/13] virtio: add vhost-user-generic and reduce copy and paste Alex Bennée
2023-04-18 16:21 ` [PATCH v2 01/13] include: attempt to document device_class_set_props Alex Bennée
2023-04-20 9:21 ` Mark Cave-Ayland
2023-05-23 20:30 ` Stefan Hajnoczi
2023-04-18 16:21 ` [PATCH v2 02/13] include/hw: document the device_class_set_parent_* fns Alex Bennée
2023-04-20 9:24 ` Mark Cave-Ayland
2023-04-18 16:21 ` [PATCH v2 03/13] hw/virtio: fix typo in VIRTIO_CONFIG_IRQ_IDX comments Alex Bennée
2023-04-20 9:25 ` Mark Cave-Ayland
2023-05-23 20:35 ` Stefan Hajnoczi
2023-04-18 16:21 ` [PATCH v2 04/13] include/hw/virtio: document virtio_notify_config Alex Bennée
2023-04-20 9:27 ` Mark Cave-Ayland
2023-05-23 20:40 ` Stefan Hajnoczi [this message]
2023-04-18 16:21 ` [PATCH v2 05/13] include/hw/virtio: add kerneldoc for virtio_init Alex Bennée
2023-04-20 9:29 ` Mark Cave-Ayland
2023-05-23 20:41 ` Stefan Hajnoczi
2023-04-18 16:21 ` [PATCH v2 06/13] include/hw/virtio: document some more usage of notifiers Alex Bennée
2023-04-20 9:32 ` Mark Cave-Ayland
2023-05-23 20:52 ` Stefan Hajnoczi
2023-04-18 16:21 ` [PATCH v2 07/13] virtio: add vhost-user-base and a generic vhost-user-device Alex Bennée
2023-04-20 9:47 ` Mark Cave-Ayland
2023-04-18 16:21 ` [PATCH v2 08/13] virtio: add PCI stub for vhost-user-device Alex Bennée
2023-04-20 9:54 ` Mark Cave-Ayland
2023-04-18 16:21 ` [PATCH v2 09/13] hw/virtio: derive vhost-user-rng from vhost-user-device Alex Bennée
2023-04-20 10:09 ` Mark Cave-Ayland
2023-04-18 16:21 ` [PATCH v2 10/13] hw/virtio: add config support to vhost-user-device Alex Bennée
2023-04-18 16:21 ` [PATCH v2 11/13] hw/virtio: derive vhost-user-gpio from vhost-user-device Alex Bennée
2023-04-20 10:12 ` Mark Cave-Ayland
2023-04-18 16:21 ` [PATCH v2 12/13] hw/virtio: derive vhost-user-i2c from vhost-user-base Alex Bennée
2023-04-20 10:18 ` Mark Cave-Ayland
2023-04-18 16:21 ` [PATCH v2 13/13] docs/system: add a basic enumeration of vhost-user devices Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523204024.GC140337@fedora \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=erik.schilling@linaro.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=viresh.kumar@linaro.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).