From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Klaus Jensen <its@irrelevant.dk>,
Keith Busch <kbusch@kernel.org>,
Jesper Devantier <j.devantier@samsung.com>,
Klaus Jensen <k.jensen@samsung.com>
Subject: [PATCH 3/4] hw/nvme: add placement handle list ranges
Date: Wed, 24 May 2023 13:19:03 +0200 [thread overview]
Message-ID: <20230524111904.91179-4-its@irrelevant.dk> (raw)
In-Reply-To: <20230524111904.91179-1-its@irrelevant.dk>
From: Klaus Jensen <k.jensen@samsung.com>
Allow the placement handles to be specified as ranges, i.e.
`fdp.ruhs=1:3-5` will attempt to assign ruh 1, 3, 4 and 5 to the
namespace.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 42 +++++++++++++++++++++++++++++++++---------
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index c4ea2033bb1c..44aba8f4d9cf 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -400,8 +400,9 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error **errp)
NvmeRuHandle *ruh;
uint8_t lbafi = NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas);
g_autofree unsigned int *ruhids = NULL;
- unsigned int *ruhid;
- char *r, *p, *token;
+ unsigned int n, m, *ruhid;
+ const char *endptr, *token;
+ char *r, *p;
uint16_t *ph;
if (!ns->params.fdp.ruhs) {
@@ -438,17 +439,40 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error **errp)
/* parse the placement handle identifiers */
while ((token = qemu_strsep(&p, ";")) != NULL) {
- if (ns->fdp.nphs++ == endgrp->fdp.nruh) {
- error_setg(errp, "too many placement handles");
- free(r);
- return false;
- }
-
- if (qemu_strtoui(token, NULL, 0, ruhid++) < 0) {
+ if (qemu_strtoui(token, &endptr, 0, &n) < 0) {
error_setg(errp, "cannot parse reclaim unit handle identifier");
free(r);
return false;
}
+
+ m = n;
+
+ /* parse range */
+ if (*endptr == '-') {
+ token = endptr + 1;
+
+ if (qemu_strtoui(token, NULL, 0, &m) < 0) {
+ error_setg(errp, "cannot parse reclaim unit handle identifier");
+ free(r);
+ return false;
+ }
+
+ if (m < n) {
+ error_setg(errp, "invalid reclaim unit handle identifier range");
+ free(r);
+ return false;
+ }
+ }
+
+ for (; n <= m; n++) {
+ if (ns->fdp.nphs++ == endgrp->fdp.nruh) {
+ error_setg(errp, "too many placement handles");
+ free(r);
+ return false;
+ }
+
+ *ruhid++ = n;
+ }
}
free(r);
--
2.40.0
next prev parent reply other threads:[~2023-05-24 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 11:19 [PATCH 0/4] hw/nvme: tp4146 misc Klaus Jensen
2023-05-24 11:19 ` [PATCH 1/4] hw/nvme: fix verification of number of ruhis Klaus Jensen
2023-05-24 11:19 ` [PATCH 2/4] hw/nvme: verify uniqueness of reclaim unit handle identifiers Klaus Jensen
2023-05-24 11:19 ` Klaus Jensen [this message]
2023-05-24 11:19 ` [PATCH 4/4] docs: update hw/nvme documentation for TP4146 Klaus Jensen
[not found] ` <CGME20230609083911eucas1p19c8484fdbfc404bdab8bec9ffe903153@eucas1p1.samsung.com>
2023-06-09 8:39 ` [PATCH 0/4] hw/nvme: tp4146 misc Jesper Devantier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524111904.91179-4-its@irrelevant.dk \
--to=its@irrelevant.dk \
--cc=j.devantier@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).