From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: <qemu-devel@nongnu.org>, <ben.widawsky@intel.com>,
<dan.j.williams@intel.com>, <mst@redhat.com>,
<peter.maydell@linaro.org>
Subject: Re: [PATCH 1/2] docs/cxl: Correct CFMW number
Date: Thu, 25 May 2023 12:42:03 +0100 [thread overview]
Message-ID: <20230525124203.00000c50@Huawei.com> (raw)
In-Reply-To: <20230519085802.2106900-1-lizhijian@cn.fujitsu.com>
On Fri, 19 May 2023 16:58:01 +0800
Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
> The 'Notes:' in this document mentioned CFMW{0-2}, but the figure missed
> CFMW2.
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> I'm totally new to CXL, so i have little confidence to this change :)
I believe this one is already fixed upstream by Brice Goglin
https://gitlab.com/qemu-project/qemu/-/commit/ca4750583a597e97cbf8cec008d228f95d22c4
Otherwise was good!
Thanks,
Jonathan
> ---
> docs/system/devices/cxl.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst
> index dce43476129..d3577a4d6da 100644
> --- a/docs/system/devices/cxl.rst
> +++ b/docs/system/devices/cxl.rst
> @@ -162,7 +162,7 @@ Example system Topology. x marks the match in each decoder level::
> |<------------------SYSTEM PHYSICAL ADDRESS MAP (1)----------------->|
> | __________ __________________________________ __________ |
> | | | | | | | |
> - | | CFMW 0 | | CXL Fixed Memory Window 1 | | CFMW 1 | |
> + | | CFMW 0 | | CXL Fixed Memory Window 1 | | CFMW 2 | |
> | | HB0 only | | Configured to interleave memory | | HB1 only | |
> | | | | memory accesses across HB0/HB1 | | | |
> | |__________| |_____x____________________________| |__________| |
> @@ -247,7 +247,7 @@ Example topology involving a switch::
> |<------------------SYSTEM PHYSICAL ADDRESS MAP (1)----------------->|
> | __________ __________________________________ __________ |
> | | | | | | | |
> - | | CFMW 0 | | CXL Fixed Memory Window 1 | | CFMW 1 | |
> + | | CFMW 0 | | CXL Fixed Memory Window 1 | | CFMW 2 | |
> | | HB0 only | | Configured to interleave memory | | HB1 only | |
> | | | | memory accesses across HB0/HB1 | | | |
> | |____x_____| |__________________________________| |__________| |
prev parent reply other threads:[~2023-05-25 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 8:58 [PATCH 1/2] docs/cxl: Correct CFMW number Li Zhijian
2023-05-19 8:58 ` [PATCH 2/2] docs/clx: Change to lowercase as others Li Zhijian
2023-05-25 11:49 ` Jonathan Cameron via
2023-05-26 2:37 ` Zhijian Li (Fujitsu)
2023-05-25 11:42 ` Jonathan Cameron via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525124203.00000c50@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).