From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael Tsirkin" <mst@redhat.com>,
"Fan Ni" <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org, linuxarm@huawei.com,
"Ira Weiny" <ira.weiny@intel.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dave Jiang" <dave.jiang@intel.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Mike Maslenkin" <mike.maslenkin@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH v7 7/7] hw/cxl/events: Add injection of Memory Module Events
Date: Fri, 26 May 2023 18:10:04 +0100 [thread overview]
Message-ID: <20230526181004.0000512d@Huawei.com> (raw)
In-Reply-To: <87h6rz8bnj.fsf@pond.sub.org>
> > +# @temperature: Device temperature in degrees Celsius.
> > +#
> > +# @dirty-shutdown-count: Number of time the device has been unable to
>
> Number of times
>
> > +# determine whether data loss may have occurred.
> > +#
> > +# @corrected-volatile-error-count: Total number of correctable errors in
> > +# volatile memory.
> > +#
> > +# @corrected-persistent-error-count: Total number correctable errors in
> > +# persistent memory
>
> Please format like
>
> # @flags: Event Record Flags. See CXL r3.0 Table 8-42 Common Event
> # Record Format, Event Record Flags for subfield definitions.
> #
> # @type: Device Event Type. See CXL r3.0 Table 8-45 Memory Module
> # Event Record for bit definitions for bit definiions.
> #
> # @health-status: Overall health summary bitmap. See CXL r3.0 Table
> # 8-100 Get Health Info Output Payload, Health Status for bit
> # definitions.
> #
> # @media-status: Overall media health summary. See CXL r3.0 Table
> # 8-100 Get Health Info Output Payload, Media Status for bit
> # definitions.
> #
> # @additional-status: See CXL r3.0 Table 8-100 Get Health Info Output
> # Payload, Additional Status for subfield definitions.
> #
> # @life-used: Percentage (0-100) of factory expected life span.
> #
> # @temperature: Device temperature in degrees Celsius.
> #
> # @dirty-shutdown-count: Number of time the device has been unable to
> # determine whether data loss may have occurred.
With "Number of times" this runs to 71 chars. reflowed appropriately for v8
> #
> # @corrected-volatile-error-count: Total number of correctable errors
> # in volatile memory.
> #
> # @corrected-persistent-error-count: Total number correctable errors
> # in persistent memory
>
> to blend in with recent commit a937b6aa739 (qapi: Reformat doc comments
> to conform to current conventions).
>
>
> > +#
next prev parent reply other threads:[~2023-05-26 17:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:09 [PATCH v7 0/7] QEMU CXL Provide mock CXL events and irq support Jonathan Cameron via
2023-05-22 15:09 ` [PATCH v7 1/7] hw/cxl/events: Add event status register Jonathan Cameron via
2023-05-22 18:33 ` Fan Ni
2023-05-22 15:09 ` [PATCH v7 2/7] hw/cxl: Move CXLRetCode definition to cxl_device.h Jonathan Cameron via
2023-05-22 18:38 ` Fan Ni
2023-05-22 15:09 ` [PATCH v7 3/7] hw/cxl/events: Wire up get/clear event mailbox commands Jonathan Cameron via
2023-05-22 19:50 ` Fan Ni
2023-05-23 10:39 ` Jonathan Cameron via
2023-05-23 14:26 ` Ira Weiny
2023-05-22 15:09 ` [PATCH v7 4/7] hw/cxl/events: Add event interrupt support Jonathan Cameron via
2023-05-22 22:41 ` Fan Ni
2023-05-23 18:37 ` Davidlohr Bueso
2023-05-22 15:09 ` [PATCH v7 5/7] hw/cxl/events: Add injection of General Media Events Jonathan Cameron via
2023-05-22 23:19 ` Fan Ni
2023-05-26 13:19 ` Markus Armbruster
2023-05-22 15:09 ` [PATCH v7 6/7] hw/cxl/events: Add injection of DRAM events Jonathan Cameron via
2023-05-23 21:52 ` Fan Ni
2023-05-26 13:25 ` Markus Armbruster
2023-05-22 15:09 ` [PATCH v7 7/7] hw/cxl/events: Add injection of Memory Module Events Jonathan Cameron via
2023-05-23 21:53 ` Fan Ni
2023-05-26 13:28 ` Markus Armbruster
2023-05-26 17:10 ` Jonathan Cameron via [this message]
2023-05-26 20:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526181004.0000512d@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave.jiang@intel.com \
--cc=eblake@redhat.com \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mike.maslenkin@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).