From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-stable@nongnu.org,
Mikhail Mitskevich <mitskevichmn@gmail.com>
Subject: [PATCH 3/4] target/s390x: Fix LOCFHR taking the wrong half of R2
Date: Fri, 26 May 2023 20:12:39 +0200 [thread overview]
Message-ID: <20230526181240.1425579-4-iii@linux.ibm.com> (raw)
In-Reply-To: <20230526181240.1425579-1-iii@linux.ibm.com>
LOCFHR should write top-to-top, but QEMU erroneously writes
bottom-to-top.
Fixes: 45aa9aa3b773 ("target/s390x: Implement load-on-condition-2 insns")
Cc: qemu-stable@nongnu.org
Reported-by: Mikhail Mitskevich <mitskevichmn@gmail.com>
Closes: https://gitlab.com/qemu-project/qemu/-/issues/1668
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/insn-data.h.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/tcg/insn-data.h.inc b/target/s390x/tcg/insn-data.h.inc
index e41672684aa..937e18ea9d9 100644
--- a/target/s390x/tcg/insn-data.h.inc
+++ b/target/s390x/tcg/insn-data.h.inc
@@ -564,7 +564,7 @@
C(0xec46, LOCGHI, RIE_g, LOC2, r1, i2, r1, 0, loc, 0)
C(0xec4e, LOCHHI, RIE_g, LOC2, r1_sr32, i2, new, r1_32h, loc, 0)
/* LOAD HIGH ON CONDITION */
- C(0xb9e0, LOCFHR, RRF_c, LOC2, r1_sr32, r2, new, r1_32h, loc, 0)
+ C(0xb9e0, LOCFHR, RRF_c, LOC2, r1_sr32, r2_sr32, new, r1_32h, loc, 0)
C(0xebe0, LOCFH, RSY_b, LOC2, r1_sr32, m2_32u, new, r1_32h, loc, 0)
/* LOAD PAIR DISJOINT */
D(0xc804, LPD, SSF, ILA, 0, 0, new_P, r3_P32, lpd, 0, MO_TEUL)
--
2.40.1
next prev parent reply other threads:[~2023-05-26 18:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 18:12 [PATCH 0/4] Fix Fedora 38 Clang on s390x Ilya Leoshkevich
2023-05-26 18:12 ` [PATCH 1/4] target/s390x: Fix LCBB overwriting the top 32 bits Ilya Leoshkevich
2023-05-26 23:11 ` Richard Henderson
2023-05-28 18:55 ` David Hildenbrand
2023-05-26 18:12 ` [PATCH 2/4] tests/tcg/s390x: Test LCBB Ilya Leoshkevich
2023-05-26 23:13 ` Richard Henderson
2023-05-28 18:55 ` David Hildenbrand
2023-05-26 18:12 ` Ilya Leoshkevich [this message]
2023-05-26 23:03 ` [PATCH 3/4] target/s390x: Fix LOCFHR taking the wrong half of R2 Richard Henderson
2023-05-28 18:55 ` David Hildenbrand
2023-05-26 18:12 ` [PATCH 4/4] tests/tcg/s390x: Test LOCFHR Ilya Leoshkevich
2023-05-26 23:14 ` Richard Henderson
2023-05-28 18:56 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526181240.1425579-4-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=mitskevichmn@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).