From: P J P <ppandit@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Jason Wang <jasowang@redhat.com>,
Michael S Tsirkin <mst@redhat.com>,
Prasad Pandit <pjp@fedoraproject.org>
Subject: [PATCH v2 2/2] vhost: release virtqueue objects in error path
Date: Mon, 29 May 2023 17:13:33 +0530 [thread overview]
Message-ID: <20230529114333.31686-3-ppandit@redhat.com> (raw)
In-Reply-To: <20230529114333.31686-1-ppandit@redhat.com>
From: Prasad Pandit <pjp@fedoraproject.org>
vhost_dev_start function does not release virtqueue objects when
event_notifier_init() function fails. Release virtqueue objects
and log a message about function failure.
Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
---
hw/virtio/vhost.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
v2: split a single patch into two.
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 6be4a0626a..1de3029ae7 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -1942,7 +1942,8 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev, bool vrings)
r = event_notifier_init(
&hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier, 0);
if (r < 0) {
- return r;
+ VHOST_OPS_DEBUG(r, "event_notifier_init failed");
+ goto fail_vq;
}
event_notifier_test_and_clear(
&hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier);
--
2.40.1
next prev parent reply other threads:[~2023-05-29 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 11:43 [PATCH v2 0/2] vhost: release memory objects in an error path P J P
2023-05-29 11:43 ` [PATCH v2 1/2] vhost: release memory_listener object in " P J P
2023-05-29 15:06 ` Peter Xu
2023-05-31 1:19 ` Jason Wang
2023-05-29 11:43 ` P J P [this message]
2023-05-29 15:06 ` [PATCH v2 2/2] vhost: release virtqueue objects " Peter Xu
2023-05-31 1:22 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529114333.31686-3-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).