From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Zhenyu Wang <zhenyu.z.wang@intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Babu Moger <babu.moger@amd.com>, Zhao Liu <zhao1.liu@intel.com>,
Zhuocheng Ding <zhuocheng.ding@intel.com>
Subject: [PATCH v2 12/17] hw/i386/pc: Support smp.clusters for x86 PC machine
Date: Mon, 29 May 2023 20:30:56 +0800 [thread overview]
Message-ID: <20230529123101.411267-13-zhao1.liu@linux.intel.com> (raw)
In-Reply-To: <20230529123101.411267-1-zhao1.liu@linux.intel.com>
From: Zhuocheng Ding <zhuocheng.ding@intel.com>
As module-level topology support is added to X86CPU, now we can enable
the support for the cluster parameter on PC machines. With this support,
we can define a 5-level x86 CPU topology with "-smp":
-smp cpus=*,maxcpus=*,sockets=*,dies=*,clusters=*,cores=*,threads=*.
Additionally, add the 5-level topology example in description of "-smp".
Signed-off-by: Zhuocheng Ding <zhuocheng.ding@intel.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
---
hw/i386/pc.c | 1 +
qemu-options.hx | 10 +++++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index bb62c994fad3..e16eef1a84e1 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1979,6 +1979,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
mc->default_cpu_type = TARGET_DEFAULT_CPU_TYPE;
mc->nvdimm_supported = true;
mc->smp_props.dies_supported = true;
+ mc->smp_props.clusters_supported = true;
mc->default_ram_id = "pc.ram";
object_class_property_add(oc, PC_MACHINE_MAX_RAM_BELOW_4G, "size",
diff --git a/qemu-options.hx b/qemu-options.hx
index b37eb9662bfe..a51fab793899 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -319,14 +319,14 @@ SRST
-smp 8,sockets=2,cores=2,threads=2,maxcpus=8
The following sub-option defines a CPU topology hierarchy (2 sockets
- totally on the machine, 2 dies per socket, 2 cores per die, 2 threads
- per core) for PC machines which support sockets/dies/cores/threads.
- Some members of the option can be omitted but their values will be
- automatically computed:
+ totally on the machine, 2 dies per socket, 2 clusters per die, 2 cores per
+ cluster, 2 threads per core) for PC machines which support sockets/dies
+ /clusters/cores/threads. Some members of the option can be omitted but
+ their values will be automatically computed:
::
- -smp 16,sockets=2,dies=2,cores=2,threads=2,maxcpus=16
+ -smp 32,sockets=2,dies=2,clusters=2,cores=2,threads=2,maxcpus=32
The following sub-option defines a CPU topology hierarchy (2 sockets
totally on the machine, 2 clusters per socket, 2 cores per cluster,
--
2.34.1
next prev parent reply other threads:[~2023-05-29 12:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 12:30 [PATCH v2 00/17] Support smp.clusters for x86 Zhao Liu
2023-05-29 12:30 ` [PATCH v2 01/17] i386: Fix comment style in topology.h Zhao Liu
2023-05-29 12:30 ` [PATCH v2 02/17] tests: Rename test-x86-cpuid.c to test-x86-topo.c Zhao Liu
2023-06-28 6:21 ` Philippe Mathieu-Daudé
2023-05-29 12:30 ` [PATCH v2 03/17] softmmu: Fix CPUSTATE.nr_cores' calculation Zhao Liu
2023-05-29 12:30 ` [PATCH v2 04/17] i386/cpu: Fix i/d-cache topology to core level for Intel CPU Zhao Liu
2023-05-29 12:30 ` [PATCH v2 05/17] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4] Zhao Liu
2023-05-29 12:30 ` [PATCH v2 06/17] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid() Zhao Liu
2023-05-29 12:30 ` [PATCH v2 07/17] i386: Introduce module-level cpu topology to CPUX86State Zhao Liu
2023-05-29 12:30 ` [PATCH v2 08/17] i386: Support modules_per_die in X86CPUTopoInfo Zhao Liu
2023-05-29 12:30 ` [PATCH v2 09/17] i386: Support module_id in X86CPUTopoIDs Zhao Liu
2023-05-29 12:30 ` [PATCH v2 10/17] i386/cpu: Introduce cluster-id to X86CPU Zhao Liu
2023-05-29 12:30 ` [PATCH v2 11/17] tests: Add test case of APIC ID for module level parsing Zhao Liu
2023-05-29 12:30 ` Zhao Liu [this message]
2023-05-29 12:30 ` [PATCH v2 13/17] i386: Add cache topology info in CPUCacheInfo Zhao Liu
2023-05-29 12:30 ` [PATCH v2 14/17] i386: Use CPUCacheInfo.share_level to encode CPUID[4] Zhao Liu
2023-05-29 12:30 ` [PATCH v2 15/17] i386: Fix NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14] Zhao Liu
2023-05-29 12:31 ` [PATCH v2 16/17] i386: Use CPUCacheInfo.share_level to encode " Zhao Liu
2023-05-29 12:31 ` [PATCH v2 17/17] i386: Add new property to control L2 cache topo in CPUID.04H Zhao Liu
2023-06-13 7:57 ` [PATCH v2 00/17] Support smp.clusters for x86 Zhao Liu
2023-06-14 1:59 ` Ma, Yongwei
2023-06-22 20:14 ` Michael S. Tsirkin
2023-06-28 1:18 ` Zhao Liu
2023-07-10 18:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529123101.411267-13-zhao1.liu@linux.intel.com \
--to=zhao1.liu@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
--cc=xiaoyao.li@intel.com \
--cc=zhao1.liu@intel.com \
--cc=zhenyu.z.wang@intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).