* [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI
@ 2023-05-30 10:20 Thomas Huth
2023-05-30 10:43 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2023-05-30 10:20 UTC (permalink / raw)
To: Mark Cave-Ayland, qemu-ppc
Cc: qemu-devel, BALATON Zoltan, Daniel Henrique Barboza
The PowerMacs have an OHCI controller soldered on the motherboard,
so this should always be enabled for the "mac99" machine.
This fixes the problem that QEMU aborts when the user tries to run
the "mac99" machine with a build that has been compiled with the
"--without-default-devices" configure switch.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/ppc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index a689d9b219..5dfbf47ef5 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -115,6 +115,7 @@ config MAC_NEWWORLD
select MAC_PMU
select UNIN_PCI
select FW_CFG_PPC
+ select USB_OHCI_PCI
config E500
bool
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI
2023-05-30 10:20 [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI Thomas Huth
@ 2023-05-30 10:43 ` Philippe Mathieu-Daudé
2023-05-30 13:36 ` Richard Henderson
2023-05-31 8:10 ` Mark Cave-Ayland
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-05-30 10:43 UTC (permalink / raw)
To: Thomas Huth, Mark Cave-Ayland, qemu-ppc
Cc: qemu-devel, BALATON Zoltan, Daniel Henrique Barboza
On 30/5/23 12:20, Thomas Huth wrote:
> The PowerMacs have an OHCI controller soldered on the motherboard,
> so this should always be enabled for the "mac99" machine.
> This fixes the problem that QEMU aborts when the user tries to run
> the "mac99" machine with a build that has been compiled with the
> "--without-default-devices" configure switch.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/ppc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI
2023-05-30 10:20 [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI Thomas Huth
2023-05-30 10:43 ` Philippe Mathieu-Daudé
@ 2023-05-30 13:36 ` Richard Henderson
2023-05-31 8:10 ` Mark Cave-Ayland
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-05-30 13:36 UTC (permalink / raw)
To: Thomas Huth, Mark Cave-Ayland, qemu-ppc
Cc: qemu-devel, BALATON Zoltan, Daniel Henrique Barboza
On 5/30/23 03:20, Thomas Huth wrote:
> The PowerMacs have an OHCI controller soldered on the motherboard,
> so this should always be enabled for the "mac99" machine.
> This fixes the problem that QEMU aborts when the user tries to run
> the "mac99" machine with a build that has been compiled with the
> "--without-default-devices" configure switch.
>
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> hw/ppc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI
2023-05-30 10:20 [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI Thomas Huth
2023-05-30 10:43 ` Philippe Mathieu-Daudé
2023-05-30 13:36 ` Richard Henderson
@ 2023-05-31 8:10 ` Mark Cave-Ayland
2 siblings, 0 replies; 4+ messages in thread
From: Mark Cave-Ayland @ 2023-05-31 8:10 UTC (permalink / raw)
To: Thomas Huth, qemu-ppc; +Cc: qemu-devel, BALATON Zoltan, Daniel Henrique Barboza
On 30/05/2023 11:20, Thomas Huth wrote:
> The PowerMacs have an OHCI controller soldered on the motherboard,
> so this should always be enabled for the "mac99" machine.
> This fixes the problem that QEMU aborts when the user tries to run
> the "mac99" machine with a build that has been compiled with the
> "--without-default-devices" configure switch.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/ppc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index a689d9b219..5dfbf47ef5 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -115,6 +115,7 @@ config MAC_NEWWORLD
> select MAC_PMU
> select UNIN_PCI
> select FW_CFG_PPC
> + select USB_OHCI_PCI
>
> config E500
> bool
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-31 8:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30 10:20 [PATCH] hw/ppc/Kconfig: MAC_NEWWORLD should always select USB_OHCI_PCI Thomas Huth
2023-05-30 10:43 ` Philippe Mathieu-Daudé
2023-05-30 13:36 ` Richard Henderson
2023-05-31 8:10 ` Mark Cave-Ayland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).