qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] target/ppc: Fix msgclrp interrupt type
@ 2023-05-30 13:07 Nicholas Piggin
  2023-05-31  6:52 ` Cédric Le Goater
  2023-06-05 11:13 ` Daniel Henrique Barboza
  0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Piggin @ 2023-05-30 13:07 UTC (permalink / raw)
  To: qemu-ppc; +Cc: Nicholas Piggin, qemu-devel, Daniel Henrique Barboza

msgclrp matches msgsndp and should clear PPC_INTERRUPT_DOORBELL.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 target/ppc/excp_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index add2bc6bfe..c13f2afa04 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -3068,7 +3068,7 @@ void helper_book3s_msgclrp(CPUPPCState *env, target_ulong rb)
         return;
     }
 
-    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_HDOORBELL, 0);
+    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_DOORBELL, 0);
 }
 
 /*
-- 
2.40.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] target/ppc: Fix msgclrp interrupt type
  2023-05-30 13:07 [PATCH v1] target/ppc: Fix msgclrp interrupt type Nicholas Piggin
@ 2023-05-31  6:52 ` Cédric Le Goater
  2023-06-05 11:13 ` Daniel Henrique Barboza
  1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2023-05-31  6:52 UTC (permalink / raw)
  To: Nicholas Piggin, qemu-ppc; +Cc: qemu-devel, Daniel Henrique Barboza

On 5/30/23 15:07, Nicholas Piggin wrote:
> msgclrp matches msgsndp and should clear PPC_INTERRUPT_DOORBELL.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>   target/ppc/excp_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index add2bc6bfe..c13f2afa04 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -3068,7 +3068,7 @@ void helper_book3s_msgclrp(CPUPPCState *env, target_ulong rb)
>           return;
>       }
>   
> -    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_HDOORBELL, 0);
> +    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_DOORBELL, 0);
>   }
>   
>   /*



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] target/ppc: Fix msgclrp interrupt type
  2023-05-30 13:07 [PATCH v1] target/ppc: Fix msgclrp interrupt type Nicholas Piggin
  2023-05-31  6:52 ` Cédric Le Goater
@ 2023-06-05 11:13 ` Daniel Henrique Barboza
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Henrique Barboza @ 2023-06-05 11:13 UTC (permalink / raw)
  To: Nicholas Piggin, qemu-ppc; +Cc: qemu-devel, Daniel Henrique Barboza



On 5/30/23 10:07, Nicholas Piggin wrote:
> msgclrp matches msgsndp and should clear PPC_INTERRUPT_DOORBELL.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel

>   target/ppc/excp_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index add2bc6bfe..c13f2afa04 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -3068,7 +3068,7 @@ void helper_book3s_msgclrp(CPUPPCState *env, target_ulong rb)
>           return;
>       }
>   
> -    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_HDOORBELL, 0);
> +    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_DOORBELL, 0);
>   }
>   
>   /*


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-05 11:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30 13:07 [PATCH v1] target/ppc: Fix msgclrp interrupt type Nicholas Piggin
2023-05-31  6:52 ` Cédric Le Goater
2023-06-05 11:13 ` Daniel Henrique Barboza

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).