From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, hreitz@redhat.com,
eblake@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH 02/11] qdev-properties-system: Lock AioContext for blk_insert_bs()
Date: Wed, 31 May 2023 13:02:22 +0200 [thread overview]
Message-ID: <20230531110231.262251-3-kwolf@redhat.com> (raw)
In-Reply-To: <20230531110231.262251-1-kwolf@redhat.com>
blk_insert_bs() requires that callers hold the AioContext lock for the
node that should be inserted. Take it.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/core/qdev-properties-system.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index d42493f630..7f6b14276a 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -147,7 +147,10 @@ static void set_drive_helper(Object *obj, Visitor *v, const char *name,
blk = blk_new(ctx, 0, BLK_PERM_ALL);
blk_created = true;
+ aio_context_acquire(ctx);
ret = blk_insert_bs(blk, bs, errp);
+ aio_context_release(ctx);
+
if (ret < 0) {
goto fail;
}
--
2.40.1
next prev parent reply other threads:[~2023-05-31 11:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 11:02 [PATCH 00/11] block: Re-enable the graph lock Kevin Wolf
2023-05-31 11:02 ` [PATCH 01/11] iotests: Test active commit with iothread and background I/O Kevin Wolf
2023-05-31 11:02 ` Kevin Wolf [this message]
2023-06-01 16:05 ` [PATCH 02/11] qdev-properties-system: Lock AioContext for blk_insert_bs() Kevin Wolf
2023-05-31 11:02 ` [PATCH 03/11] test-block-iothread: " Kevin Wolf
2023-05-31 11:02 ` [PATCH 04/11] block: Fix AioContext locking in bdrv_open_child() Kevin Wolf
2023-05-31 11:02 ` [PATCH 05/11] block: Fix AioContext locking in bdrv_attach_child_common() Kevin Wolf
2023-05-31 11:02 ` [PATCH 06/11] block: Fix AioContext locking in bdrv_reopen_parse_file_or_backing() Kevin Wolf
2023-05-31 11:02 ` [PATCH 07/11] block: Fix AioContext locking in bdrv_open_inherit() Kevin Wolf
2023-05-31 11:02 ` [PATCH 08/11] block: Fix AioContext locking in bdrv_open_backing_file() Kevin Wolf
2023-05-31 11:02 ` [PATCH 09/11] blockjob: Fix AioContext locking in block_job_add_bdrv() Kevin Wolf
2023-05-31 11:02 ` [PATCH 10/11] graph-lock: Unlock the AioContext while polling Kevin Wolf
2023-05-31 11:02 ` [PATCH 11/11] Revert "graph-lock: Disable locking for now" Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531110231.262251-3-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).