qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>, <fan.ni@samsung.com>,
	<qemu-devel@nongnu.org>
Subject: Re: [PATCH v3] hw/cxl: Fix CFMW config memory leak
Date: Wed, 31 May 2023 12:08:23 +0100	[thread overview]
Message-ID: <20230531120823.00001a6c@Huawei.com> (raw)
In-Reply-To: <5ac2e71e-7bc0-ee84-fce2-8d0b6e137a3e@linaro.org>

On Wed, 31 May 2023 09:51:43 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

> On 31/5/23 08:07, Li Zhijian wrote:
> > Allocate targets and targets[n] resources when all sanity checks are
> > passed to avoid memory leaks.
> > 
> > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> > ---
> > V3: allocte further resource when we can't fail # Philippe  
> 
> Thanks for the v3!
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks.  I've added this near the top of my queue so will send
it out along with other similar fixes as a series for Michael
to consider picking up.

Jonathan

> 
> > V2: Delete unnecesarry check
> > ---
> >   hw/cxl/cxl-host.c | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)  
> 



  reply	other threads:[~2023-05-31 11:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31  6:07 [PATCH v3] hw/cxl: Fix CFMW config memory leak Li Zhijian
2023-05-31  7:51 ` Philippe Mathieu-Daudé
2023-05-31 11:08   ` Jonathan Cameron via [this message]
2023-08-05  5:46     ` Michael Tokarev
2023-08-08 14:44       ` Jonathan Cameron via
2023-09-08 17:02         ` Michael Tokarev
2023-09-11  9:18           ` Jonathan Cameron via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531120823.00001a6c@Huawei.com \
    --to=qemu-devel@nongnu.org \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=fan.ni@samsung.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=philmd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).