From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v3 7/9] tests/qtest: capture RESUME events during migration
Date: Wed, 31 May 2023 14:23:58 +0100 [thread overview]
Message-ID: <20230531132400.1129576-8-berrange@redhat.com> (raw)
In-Reply-To: <20230531132400.1129576-1-berrange@redhat.com>
When running migration tests we monitor for a STOP event so we can skip
redundant waits. This will be needed for the RESUME event too shortly.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qtest/migration-helpers.c | 12 ++++++++++++
tests/qtest/migration-helpers.h | 2 ++
tests/qtest/migration-test.c | 5 +++++
3 files changed, 19 insertions(+)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index 884d8a2e07..d50b565967 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest/migration-helpers.c
@@ -35,6 +35,18 @@ bool migrate_watch_for_stop(QTestState *who, const char *name,
return false;
}
+bool migrate_watch_for_resume(QTestState *who, const char *name,
+ QDict *event, void *opaque)
+{
+ bool *seen = opaque;
+
+ if (g_str_equal(name, "RESUME")) {
+ *seen = true;
+ }
+
+ return false;
+}
+
/*
* Send QMP command "migrate".
* Arguments are built from @fmt... (formatted like
diff --git a/tests/qtest/migration-helpers.h b/tests/qtest/migration-helpers.h
index aab0745cfe..009e250e90 100644
--- a/tests/qtest/migration-helpers.h
+++ b/tests/qtest/migration-helpers.h
@@ -17,6 +17,8 @@
bool migrate_watch_for_stop(QTestState *who, const char *name,
QDict *event, void *opaque);
+bool migrate_watch_for_resume(QTestState *who, const char *name,
+ QDict *event, void *opaque);
G_GNUC_PRINTF(3, 4)
void migrate_qmp(QTestState *who, const char *uri, const char *fmt, ...);
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d8b4282abc..aee25e1c4f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -44,6 +44,7 @@ unsigned start_address;
unsigned end_address;
static bool uffd_feature_thread_id;
static bool got_stop;
+static bool got_resume;
/*
* Dirtylimit stop working if dirty page rate error
@@ -607,6 +608,7 @@ static int test_migrate_start(QTestState **from, QTestState **to,
}
got_stop = false;
+ got_resume = false;
bootpath = g_strdup_printf("%s/bootsect", tmpfs);
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
/* the assembled x86 boot sector should be exactly one sector large */
@@ -712,6 +714,9 @@ static int test_migrate_start(QTestState **from, QTestState **to,
args->opts_target ? args->opts_target : "",
ignore_stderr);
*to = qtest_init(cmd_target);
+ qtest_qmp_set_event_callback(*to,
+ migrate_watch_for_resume,
+ &got_resume);
/*
* Remove shmem file immediately to avoid memory leak in test failed case.
--
2.40.1
next prev parent reply other threads:[~2023-05-31 13:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 13:23 [PATCH v3 0/9] tests/qtest: make migration-test massively faster Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 1/9] tests/qtest: add various qtest_qmp_assert_success() variants Daniel P. Berrangé
2023-06-01 9:23 ` Thomas Huth
2023-06-01 12:48 ` Daniel P. Berrangé
2023-06-01 12:04 ` Juan Quintela
2023-06-01 12:20 ` Juan Quintela
2023-06-01 12:51 ` Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 2/9] tests/qtest: add support for callback to receive QMP events Daniel P. Berrangé
2023-05-31 14:57 ` Thomas Huth
2023-06-01 12:14 ` Juan Quintela
2023-06-01 12:56 ` Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test Daniel P. Berrangé
2023-06-01 9:26 ` Thomas Huth
2023-06-01 9:32 ` Daniel P. Berrangé
2023-06-01 12:17 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 4/9] tests/qtest: get rid of some 'qtest_qmp' usage " Daniel P. Berrangé
2023-06-01 9:28 ` Thomas Huth
2023-06-01 12:10 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 5/9] tests/qtest: switch to using event callbacks for STOP event Daniel P. Berrangé
2023-06-01 9:31 ` Thomas Huth
2023-06-01 12:23 ` Juan Quintela
2023-05-31 13:23 ` [PATCH v3 6/9] tests/qtest: replace wait_command() with qtest_qmp_assert_success Daniel P. Berrangé
2023-06-01 9:37 ` Thomas Huth
2023-06-01 12:27 ` Juan Quintela
2023-05-31 13:23 ` Daniel P. Berrangé [this message]
2023-06-01 9:38 ` [PATCH v3 7/9] tests/qtest: capture RESUME events during migration Thomas Huth
2023-06-01 12:31 ` Juan Quintela
2023-06-01 12:34 ` Daniel P. Berrangé
2023-06-01 12:37 ` Juan Quintela
2023-06-01 12:44 ` Daniel P. Berrangé
2023-05-31 13:23 ` [PATCH v3 8/9] tests/qtest: make more migration pre-copy scenarios run non-live Daniel P. Berrangé
2023-06-01 9:47 ` Thomas Huth
2023-06-01 12:33 ` Juan Quintela
2023-06-01 12:38 ` Daniel P. Berrangé
2023-06-01 16:09 ` Thomas Huth
2023-06-01 16:17 ` Daniel P. Berrangé
2023-06-01 16:26 ` Peter Xu
2023-06-01 15:30 ` Peter Xu
2023-06-01 15:39 ` Daniel P. Berrangé
2023-06-01 15:53 ` Peter Xu
2023-06-01 15:55 ` Daniel P. Berrangé
2023-06-01 16:17 ` Peter Xu
2023-06-01 16:35 ` Daniel P. Berrangé
2023-06-01 16:59 ` Peter Xu
2023-06-01 22:58 ` Juan Quintela
2023-06-01 22:55 ` Juan Quintela
2023-05-31 13:24 ` [PATCH v3 9/9] tests/qtest: massively speed up migration-test Daniel P. Berrangé
2023-06-01 10:04 ` Thomas Huth
2023-06-01 15:46 ` Peter Xu
2023-06-01 16:05 ` Daniel P. Berrangé
2023-06-01 16:22 ` Peter Xu
2023-06-01 16:36 ` Daniel P. Berrangé
2023-06-01 17:04 ` Peter Xu
2023-06-01 23:00 ` Juan Quintela
2023-06-01 23:43 ` Peter Xu
2023-07-10 9:35 ` Daniel P. Berrangé
2023-07-10 9:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531132400.1129576-8-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).