qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Ani Sinha <anisinha@redhat.com>
Cc: qemu-devel@nongnu.org, Zhenyu Wang <zhenyu.z.wang@intel.com>,
	Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v2 1/3] hw/smbios: Fix smbios_smp_sockets caculation
Date: Thu,  1 Jun 2023 17:29:50 +0800	[thread overview]
Message-ID: <20230601092952.1114727-2-zhao1.liu@linux.intel.com> (raw)
In-Reply-To: <20230601092952.1114727-1-zhao1.liu@linux.intel.com>

From: Zhao Liu <zhao1.liu@intel.com>

Here're 2 mistakes:
1. 003f230e37d7 ("machine: Tweak the order of topology members in struct
   CpuTopology") changes the meaning of smp.cores but doesn't fix
   original smp.cores uses. And because of the introduction of cluster,
   now smp.cores means the number of cores in one cluster. So smp.cores
   * smp.threads just means the cpus in a cluster not in a socket.
2. smp.cpus means the number of initial online cpus, not the total
   number of cpus. For such topology calculation, smp.max_cpus
   should be considered.

Since the number of sockets has already been recorded in smp structure,
use smp.sockets directly.

Fixes: 003f230e37d7 ("machine: Tweak the order of topology members in struct CpuTopology")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 hw/smbios/smbios.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index d2007e70fb05..d67415d44dd8 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -1088,8 +1088,7 @@ void smbios_get_tables(MachineState *ms,
         smbios_build_type_2_table();
         smbios_build_type_3_table();
 
-        smbios_smp_sockets = DIV_ROUND_UP(ms->smp.cpus,
-                                          ms->smp.cores * ms->smp.threads);
+        smbios_smp_sockets = ms->smp.sockets;
         assert(smbios_smp_sockets >= 1);
 
         for (i = 0; i < smbios_smp_sockets; i++) {
-- 
2.34.1



  reply	other threads:[~2023-06-01  9:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01  9:29 [PATCH v2 0/3] hw/smbios: Cleanup topology related variables Zhao Liu
2023-06-01  9:29 ` Zhao Liu [this message]
2023-06-07 14:35   ` [PATCH v2 1/3] hw/smbios: Fix smbios_smp_sockets caculation Igor Mammedov
2023-06-08  2:48     ` Zhao Liu
2023-06-01  9:29 ` [PATCH v2 2/3] hw/smbios: Fix thread count in type4 Zhao Liu
2023-06-07 14:49   ` Igor Mammedov
2023-06-08  2:51     ` Zhao Liu
2023-06-08  8:28       ` Igor Mammedov
2023-08-05  5:58   ` Michael Tokarev
2023-08-05  6:00     ` Michael Tokarev
2023-08-07  9:56       ` Igor Mammedov
2023-08-07 10:06         ` Michael Tokarev
2023-08-07 10:11           ` Igor Mammedov
2023-08-07 14:31             ` Zhao Liu
2023-08-09 13:39               ` Igor Mammedov
2023-06-01  9:29 ` [PATCH v2 3/3] hw/smbios: Fix core " Zhao Liu
2023-06-07 14:51   ` Igor Mammedov
2023-06-08  2:52     ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230601092952.1114727-2-zhao1.liu@linux.intel.com \
    --to=zhao1.liu@linux.intel.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhao1.liu@intel.com \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).