From: Stefan Hajnoczi <stefanha@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PULL 01/11] *-user: remove the guest_user_syscall tracepoints
Date: Thu, 1 Jun 2023 09:54:22 -0400 [thread overview]
Message-ID: <20230601135422.GE1538357@fedora> (raw)
In-Reply-To: <5c0e79d6-6810-5429-656a-041e114b9b5e@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
On Wed, May 31, 2023 at 02:29:49PM -0700, Richard Henderson wrote:
> On 5/31/23 12:48, Stefan Hajnoczi wrote:
> > --- a/bsd-user/freebsd/os-syscall.c
> > +++ b/bsd-user/freebsd/os-syscall.c
> > @@ -531,7 +531,6 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1,
> > CPUState *cpu = env_cpu(cpu_env);
> > abi_long ret;
> > - trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8);
> > if (do_strace) {
> > print_freebsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6);
> > }
> > @@ -541,7 +540,6 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, abi_long arg1,
> > if (do_strace) {
> > print_freebsd_syscall_ret(num, ret);
> > }
> > - trace_guest_user_syscall_ret(cpu, num, ret);
> > return ret;
> > }
>
> Failed to remove the now unused cpu variable:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/4387911615#L6426
>
> ../bsd-user/freebsd/os-syscall.c:531:15: error: unused variable 'cpu'
> [-Werror,-Wunused-variable]
> CPUState *cpu = env_cpu(cpu_env);
> ^
> 1 error generated.
I'll send a v2 with the unused variable warning fixed.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
parent reply other threads:[~2023-06-01 13:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5c0e79d6-6810-5429-656a-041e114b9b5e@linaro.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601135422.GE1538357@fedora \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).