From: Andrew Jones <ajones@ventanamicro.com>
To: Robbin Ehn <rehn@rivosinc.com>
Cc: qemu-devel@nongnu.org, laurent@vivier.eu, qemu-riscv@nongnu.org,
richard.henderson@linaro.org
Subject: Re: [RFC v2] linux-user/riscv: Add syscall riscv_hwprobe
Date: Fri, 2 Jun 2023 17:07:01 +0200 [thread overview]
Message-ID: <20230602-6e13ca96e3e8064c96abf9bf@orel> (raw)
In-Reply-To: <024ee92f725f4ffd2952f472861ba9b415f4cde3.camel@rivosinc.com>
On Fri, Jun 02, 2023 at 04:39:20PM +0200, Robbin Ehn wrote:
> On Fri, 2023-06-02 at 16:02 +0200, Andrew Jones wrote:
> > On Fri, Jun 02, 2023 at 11:41:11AM +0200, Robbin Ehn wrote:
...
> > > +#if defined(TARGET_RISCV)
> > > + case TARGET_NR_riscv_hwprobe:
> > > + {
> >
> > The { goes under the c of case, which will shift all the below four spaces
> > left as well.
>
> This was an attempt to blend in, i.e. same style as the preceding case.
> I'll change, thanks.
Hmm, I see. This function does have many cases with the indented format,
but not all of them, and the rest of the code base doesn't indent. I won't
insist on changing this, as long as checkpatch isn't complaining.
Thanks,
drew
next prev parent reply other threads:[~2023-06-02 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 9:41 [RFC v2] linux-user/riscv: Add syscall riscv_hwprobe Robbin Ehn
2023-06-02 14:02 ` Andrew Jones
2023-06-02 14:39 ` Robbin Ehn
2023-06-02 15:07 ` Andrew Jones [this message]
2023-06-03 3:00 ` Richard Henderson
2023-06-05 14:27 ` Robbin Ehn
2023-06-03 2:58 ` Richard Henderson
2023-06-03 15:50 ` Andrew Jones
2023-06-03 17:48 ` Richard Henderson
2023-06-03 2:57 ` Richard Henderson
2023-06-05 14:23 ` Robbin Ehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602-6e13ca96e3e8064c96abf9bf@orel \
--to=ajones@ventanamicro.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=rehn@rivosinc.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).