* [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices
@ 2023-06-02 17:33 Eugenio Pérez
2023-06-06 1:32 ` Jason Wang
2023-06-07 10:08 ` Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Eugenio Pérez @ 2023-06-02 17:33 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Cindy Lu, Jason Wang, Michael S. Tsirkin,
Hawkins Jiawei, Lei Yang
QEMU does not emulate it so it must be disabled as long as the backend
does not support it.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
net/vhost-vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 5360924ba0..427a57dd6f 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = {
VIRTIO_F_VERSION_1,
VIRTIO_NET_F_CSUM,
VIRTIO_NET_F_GUEST_CSUM,
+ VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
VIRTIO_NET_F_GSO,
VIRTIO_NET_F_GUEST_TSO4,
VIRTIO_NET_F_GUEST_TSO6,
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices
2023-06-02 17:33 [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices Eugenio Pérez
@ 2023-06-06 1:32 ` Jason Wang
2023-06-07 8:19 ` Lei Yang
2023-06-07 10:08 ` Michael Tokarev
1 sibling, 1 reply; 5+ messages in thread
From: Jason Wang @ 2023-06-06 1:32 UTC (permalink / raw)
To: Eugenio Pérez
Cc: qemu-devel, Laurent Vivier, Cindy Lu, Michael S. Tsirkin,
Hawkins Jiawei, Lei Yang
On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> QEMU does not emulate it so it must be disabled as long as the backend
> does not support it.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
> ---
> net/vhost-vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 5360924ba0..427a57dd6f 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = {
> VIRTIO_F_VERSION_1,
> VIRTIO_NET_F_CSUM,
> VIRTIO_NET_F_GUEST_CSUM,
> + VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
> VIRTIO_NET_F_GSO,
> VIRTIO_NET_F_GUEST_TSO4,
> VIRTIO_NET_F_GUEST_TSO6,
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices
2023-06-06 1:32 ` Jason Wang
@ 2023-06-07 8:19 ` Lei Yang
0 siblings, 0 replies; 5+ messages in thread
From: Lei Yang @ 2023-06-07 8:19 UTC (permalink / raw)
To: Jason Wang
Cc: Eugenio Pérez, qemu-devel, Laurent Vivier, Cindy Lu,
Michael S. Tsirkin, Hawkins Jiawei
QE tested sanity testing for this patch on the vhost_vdpa device,
everything works fine.
Tested-by: Lei Yang <leiyang@redhat.com>
On Tue, Jun 6, 2023 at 9:33 AM Jason Wang <jasowang@redhat.com> wrote:
>
> On Sat, Jun 3, 2023 at 1:33 AM Eugenio Pérez <eperezma@redhat.com> wrote:
> >
> > QEMU does not emulate it so it must be disabled as long as the backend
> > does not support it.
> >
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>
> Acked-by: Jason Wang <jasowang@redhat.com>
>
> Thanks
>
> > ---
> > net/vhost-vdpa.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> > index 5360924ba0..427a57dd6f 100644
> > --- a/net/vhost-vdpa.c
> > +++ b/net/vhost-vdpa.c
> > @@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = {
> > VIRTIO_F_VERSION_1,
> > VIRTIO_NET_F_CSUM,
> > VIRTIO_NET_F_GUEST_CSUM,
> > + VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
> > VIRTIO_NET_F_GSO,
> > VIRTIO_NET_F_GUEST_TSO4,
> > VIRTIO_NET_F_GUEST_TSO6,
> > --
> > 2.31.1
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices
2023-06-02 17:33 [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices Eugenio Pérez
2023-06-06 1:32 ` Jason Wang
@ 2023-06-07 10:08 ` Michael Tokarev
2023-06-07 14:04 ` Eugenio Perez Martin
1 sibling, 1 reply; 5+ messages in thread
From: Michael Tokarev @ 2023-06-07 10:08 UTC (permalink / raw)
To: Eugenio Pérez, qemu-devel
Cc: Laurent Vivier, Cindy Lu, Jason Wang, Michael S. Tsirkin,
Hawkins Jiawei, Lei Yang
02.06.2023 20:33, Eugenio Pérez wrote:
> QEMU does not emulate it so it must be disabled as long as the backend
> does not support it.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> net/vhost-vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
Is it -stable material?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices
2023-06-07 10:08 ` Michael Tokarev
@ 2023-06-07 14:04 ` Eugenio Perez Martin
0 siblings, 0 replies; 5+ messages in thread
From: Eugenio Perez Martin @ 2023-06-07 14:04 UTC (permalink / raw)
To: mjt
Cc: qemu-devel, Laurent Vivier, Cindy Lu, Jason Wang,
Michael S. Tsirkin, Hawkins Jiawei, Lei Yang
On Wed, Jun 7, 2023 at 12:08 PM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 02.06.2023 20:33, Eugenio Pérez wrote:
> > QEMU does not emulate it so it must be disabled as long as the backend
> > does not support it.
> >
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > ---
> > net/vhost-vdpa.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Is it -stable material?
>
Yes, I forgot to CC qemu-stable here too.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-07 14:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 17:33 [PATCH] vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices Eugenio Pérez
2023-06-06 1:32 ` Jason Wang
2023-06-07 8:19 ` Lei Yang
2023-06-07 10:08 ` Michael Tokarev
2023-06-07 14:04 ` Eugenio Perez Martin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).