* [PATCH] target/hppa/meson: Only build int_helper.o with system emulation
@ 2023-06-02 22:30 Philippe Mathieu-Daudé
2023-06-03 3:39 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-02 22:30 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Philippe Mathieu-Daudé
int_helper.c only contains system emulation code:
remove the #ifdef'ry and move the file to the meson
softmmu source set.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/hppa/int_helper.c | 3 ---
target/hppa/meson.build | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c
index f599dccfff..d2480b163b 100644
--- a/target/hppa/int_helper.c
+++ b/target/hppa/int_helper.c
@@ -25,7 +25,6 @@
#include "hw/core/cpu.h"
#include "hw/hppa/hppa_hardware.h"
-#ifndef CONFIG_USER_ONLY
static void eval_interrupt(HPPACPU *cpu)
{
CPUState *cs = CPU(cpu);
@@ -273,5 +272,3 @@ bool hppa_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
}
return false;
}
-
-#endif /* !CONFIG_USER_ONLY */
diff --git a/target/hppa/meson.build b/target/hppa/meson.build
index 81b4b4e617..83b1e0ee7d 100644
--- a/target/hppa/meson.build
+++ b/target/hppa/meson.build
@@ -7,13 +7,13 @@ hppa_ss.add(files(
'fpu_helper.c',
'gdbstub.c',
'helper.c',
- 'int_helper.c',
'op_helper.c',
'translate.c',
))
hppa_softmmu_ss = ss.source_set()
hppa_softmmu_ss.add(files(
+ 'int_helper.c',
'machine.c',
'mem_helper.c',
'sys_helper.c',
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/hppa/meson: Only build int_helper.o with system emulation
2023-06-02 22:30 [PATCH] target/hppa/meson: Only build int_helper.o with system emulation Philippe Mathieu-Daudé
@ 2023-06-03 3:39 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2023-06-03 3:39 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
On 6/2/23 15:30, Philippe Mathieu-Daudé wrote:
> int_helper.c only contains system emulation code:
> remove the #ifdef'ry and move the file to the meson
> softmmu source set.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/hppa/int_helper.c | 3 ---
> target/hppa/meson.build | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-03 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 22:30 [PATCH] target/hppa/meson: Only build int_helper.o with system emulation Philippe Mathieu-Daudé
2023-06-03 3:39 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).