From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC5CFC7EE29 for ; Fri, 2 Jun 2023 22:47:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5DXe-0005zC-7n; Fri, 02 Jun 2023 18:46:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5DXc-0005rg-LZ for qemu-devel@nongnu.org; Fri, 02 Jun 2023 18:46:40 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5DXa-00067s-Pr for qemu-devel@nongnu.org; Fri, 02 Jun 2023 18:46:40 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f6077660c6so24407605e9.0 for ; Fri, 02 Jun 2023 15:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685745996; x=1688337996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bVMIqqWV5g+QPtoI6znu8aw+zNebYRSC5VAPbRhIAk4=; b=RAAKIvFOKZ4BOsaT5LTgvcBeqp6hGvTEFbek+gSjeDi2d5N5OWU+Kp89JLZfEhLR4j /4n54KJJihRRNi2+ggEzR3+TsUk1DiFYFXdFupO7Xgxjlh1Oajm4QZ9Mt3bycxmPUHW4 hBLiNpbvZA96Ll7wy3aqO6U5T8JWAx4l2I5Qx7TOxjsVIhzDrIAuAsvjHhRXdCtqOE39 bFS0zz6M9cvorr05rUYjGnUIT6Om3NaNY0Ykon4lQYS6illBsVC0W+KTdsPwzwqavjNk NsAsDyJFp5n5lG16yA88FFrf4BzgQyo59BVqrkAhj71YNHRctfpBz0HJaxTPTDwpRjrr h9gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685745996; x=1688337996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bVMIqqWV5g+QPtoI6znu8aw+zNebYRSC5VAPbRhIAk4=; b=Ueo7Uc+0FHNanB6U8otkLnU5Ju9xTeayi2dm9krQ44zofAxrLEFbwX+4UQzTpq4nWl LWhHI6dne9KROJ6MmmaFIbYeKQSIyuF1ToBmGOjMBYZwl04yP1ZVMyMC2tndUWi+gAp7 59XfhSZzUrKrJbmyE/qgysfZxSL2/wTTKFBOVBrf8gkivomRvUQeYkDyXYWgsA6lo7ND b424TCIlQkDvoiVfD8VdBaK90K1+zTssVQXGHvYaQGjpMl3KT8jOlygCeFev9ItH+oUt VVnxF5vehORYjYJyAqmnKLHZfWAlVaKAXZ158VRuLTA8FeG6r1/pqBpHBRLPuaqfQudy wrDw== X-Gm-Message-State: AC+VfDz63EfTspbBJetpkzrNlGWT4U6yHenkEY9hbvGbNUmG0UXIjVV3 nvwf2o2Ywnp5hAdquo/dXT6lWZ5Dz9X38ZP6H1c= X-Google-Smtp-Source: ACHHUZ4Q4twJSoY3XMmJbWYrefvVtL1UE8CLH+J6U6uDUsz8RGnRJU7yTdvWv3IcOjzvgQ38OAB2sg== X-Received: by 2002:adf:cc91:0:b0:30a:e70d:9e73 with SMTP id p17-20020adfcc91000000b0030ae70d9e73mr1013224wrj.33.1685745996549; Fri, 02 Jun 2023 15:46:36 -0700 (PDT) Received: from localhost.localdomain ([176.187.218.254]) by smtp.gmail.com with ESMTPSA id z16-20020a7bc7d0000000b003f605814850sm6780530wmk.37.2023.06.02.15.46.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 02 Jun 2023 15:46:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/2] target/i386/helper: Remove do_cpu_sipi() stub for user-mode emulation Date: Sat, 3 Jun 2023 00:46:27 +0200 Message-Id: <20230602224628.59546-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230602224628.59546-1-philmd@linaro.org> References: <20230602224628.59546-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Since commit 604664726f ("target/i386: Restrict cpu_exec_interrupt() handler to sysemu"), do_cpu_sipi() isn't called anymore on user emulation. Remove the now pointless stub. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.h | 3 ++- target/i386/helper.c | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 7201a71de8..cd047e0410 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2285,7 +2285,6 @@ static inline void cpu_get_tb_cpu_state(CPUX86State *env, target_ulong *pc, } void do_cpu_init(X86CPU *cpu); -void do_cpu_sipi(X86CPU *cpu); #define MCE_INJECT_BROADCAST 1 #define MCE_INJECT_UNCOND_AO 2 @@ -2419,6 +2418,8 @@ void x86_cpu_set_default_version(X86CPUVersion version); #ifndef CONFIG_USER_ONLY +void do_cpu_sipi(X86CPU *cpu); + #define APIC_DEFAULT_ADDRESS 0xfee00000 #define APIC_SPACE_SIZE 0x100000 diff --git a/target/i386/helper.c b/target/i386/helper.c index 36bf2107e7..792c8eb45e 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -611,9 +611,6 @@ void do_cpu_sipi(X86CPU *cpu) void do_cpu_init(X86CPU *cpu) { } -void do_cpu_sipi(X86CPU *cpu) -{ -} #endif #ifndef CONFIG_USER_ONLY -- 2.38.1