From: Sam Li <faithilikerun@gmail.com>
To: qemu-devel@nongnu.org
Cc: dlemoal@kernel.org, dmitry.fomichev@wdc.com, stefanha@redhat.com,
hare@suse.de, qemu-block@nongnu.org,
Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Sam Li <faithilikerun@gmail.com>
Subject: [PATCH 2/2] block/file-posix: fix wps checking in raw_co_prw
Date: Sun, 4 Jun 2023 14:16:58 +0800 [thread overview]
Message-ID: <20230604061658.49004-2-faithilikerun@gmail.com> (raw)
In-Reply-To: <20230604061658.49004-1-faithilikerun@gmail.com>
If the write operation fails and the wps is NULL, then accessing it will
lead to data corruption.
Solving the issue by adding a nullptr checking in get_zones_wp() where
the wps is used.
This issue is found by Peter Maydell using the Coverity Tool (CID
1512459).
Signed-off-by: Sam Li <faithilikerun@gmail.com>
---
block/file-posix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 0d9d179a35..620942bf40 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1340,6 +1340,10 @@ static int get_zones_wp(BlockDriverState *bs, int fd, int64_t offset,
rep_size = sizeof(struct blk_zone_report) + nrz * sizeof(struct blk_zone);
g_autofree struct blk_zone_report *rep = NULL;
+ if (!wps) {
+ return -1;
+ }
+
rep = g_malloc(rep_size);
blkz = (struct blk_zone *)(rep + 1);
while (n < nrz) {
--
2.40.1
next prev parent reply other threads:[~2023-06-04 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 6:16 [PATCH 1/2] block/file-posix: fix g_file_get_contents return path Sam Li
2023-06-04 6:16 ` Sam Li [this message]
2023-06-07 16:08 ` [PATCH 2/2] block/file-posix: fix wps checking in raw_co_prw Stefan Hajnoczi
2023-06-07 13:51 ` [PATCH 1/2] block/file-posix: fix g_file_get_contents return path Matthew Rosato
2023-06-07 16:04 ` Stefan Hajnoczi
2023-07-05 14:54 ` Matthew Rosato
2023-07-27 11:46 ` Matthew Rosato
2023-07-27 11:51 ` Sam Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230604061658.49004-2-faithilikerun@gmail.com \
--to=faithilikerun@gmail.com \
--cc=dlemoal@kernel.org \
--cc=dmitry.fomichev@wdc.com \
--cc=hare@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).