From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, peter.maydell@linaro.org,
alex.bennee@linaro.org, jsnow@redhat.com,
kconsul@linux.vnet.ibm.com
Subject: [PATCH 0/2] Fix venv issues with Avocado by reverting to an older version
Date: Mon, 5 Jun 2023 09:58:21 +0200 [thread overview]
Message-ID: <20230605075823.48871-1-pbonzini@redhat.com> (raw)
Bumping avocado to version 101 has two issues. First, there are problems
where Avocado is not logging of command lines or terminal output, and not
collecting Python logs outside the avocado namespace.
Second, the recent changes to Python handling mean that there is a single
virtual environment for all the build, instead of a separate one for testing.
Requiring a too-new version of avocado causes conflicts with any avocado
plugins installed on the host:
$ make check-venv
make[1]: Entering directory '/home/berrange/src/virt/qemu/build'
GIT ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc
VENVPIP install -e /home/berrange/src/virt/qemu/python/
VENVPIP install -r /home/berrange/src/virt/qemu/tests/requirements.txt
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
avocado-framework-plugin-varianter-yaml-to-mux 98.0 requires avocado-framework==98.0, but you have avocado-framework 101.0 which is incompatible.
avocado-framework-plugin-result-html 98.0 requires avocado-framework==98.0, but you have avocado-framework 101.0 which is incompatible.
make[1]: Leaving directory '/home/berrange/src/virt/qemu/build'
To avoid this issue, tests/requirements.txt should use a ">=" constraint
and the version of Avocado should be limited to what distros provide
in the system packages. Only Fedora has Avocado, and more specifically
version 92.0. For now, this series reverts to the older requirement
(version >=88.1) while leaving further version bumps to future changes.
Paolo
Paolo Bonzini (2):
Revert "tests/requirements.txt: bump up avocado-framework version to
101.0"
tests: update avocado installation to use mkvenv
python/tests/minreqs.txt | 3 ++-
tests/Makefile.include | 26 +++++++++++++-------------
tests/requirements.txt | 9 ---------
3 files changed, 15 insertions(+), 23 deletions(-)
delete mode 100644 tests/requirements.txt
--
2.40.1
next reply other threads:[~2023-06-05 7:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 7:58 Paolo Bonzini [this message]
2023-06-05 7:58 ` [PATCH 1/2] Revert "tests/requirements.txt: bump up avocado-framework version to 101.0" Paolo Bonzini
2023-06-05 7:58 ` [PATCH 2/2] tests: update avocado installation to use mkvenv Paolo Bonzini
2023-06-05 9:46 ` [PATCH 0/2] Fix venv issues with Avocado by reverting to an older version Peter Maydell
2023-06-05 10:51 ` Paolo Bonzini
2023-06-05 10:58 ` Peter Maydell
2023-06-05 15:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605075823.48871-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kconsul@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).