From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-stable@nongnu.org,
Mikhail Mitskevich <mitskevichmn@gmail.com>,
David Hildenbrand <david@redhat.com>
Subject: [PULL 03/18] target/s390x: Fix LOCFHR taking the wrong half of R2
Date: Tue, 6 Jun 2023 07:56:06 +0200 [thread overview]
Message-ID: <20230606055621.523175-4-thuth@redhat.com> (raw)
In-Reply-To: <20230606055621.523175-1-thuth@redhat.com>
From: Ilya Leoshkevich <iii@linux.ibm.com>
LOCFHR should write top-to-top, but QEMU erroneously writes
bottom-to-top.
Fixes: 45aa9aa3b773 ("target/s390x: Implement load-on-condition-2 insns")
Cc: qemu-stable@nongnu.org
Reported-by: Mikhail Mitskevich <mitskevichmn@gmail.com>
Closes: https://gitlab.com/qemu-project/qemu/-/issues/1668
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230526181240.1425579-4-iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/s390x/tcg/insn-data.h.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/tcg/insn-data.h.inc b/target/s390x/tcg/insn-data.h.inc
index e41672684a..937e18ea9d 100644
--- a/target/s390x/tcg/insn-data.h.inc
+++ b/target/s390x/tcg/insn-data.h.inc
@@ -564,7 +564,7 @@
C(0xec46, LOCGHI, RIE_g, LOC2, r1, i2, r1, 0, loc, 0)
C(0xec4e, LOCHHI, RIE_g, LOC2, r1_sr32, i2, new, r1_32h, loc, 0)
/* LOAD HIGH ON CONDITION */
- C(0xb9e0, LOCFHR, RRF_c, LOC2, r1_sr32, r2, new, r1_32h, loc, 0)
+ C(0xb9e0, LOCFHR, RRF_c, LOC2, r1_sr32, r2_sr32, new, r1_32h, loc, 0)
C(0xebe0, LOCFH, RSY_b, LOC2, r1_sr32, m2_32u, new, r1_32h, loc, 0)
/* LOAD PAIR DISJOINT */
D(0xc804, LPD, SSF, ILA, 0, 0, new_P, r3_P32, lpd, 0, MO_TEUL)
--
2.31.1
next prev parent reply other threads:[~2023-06-06 5:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 5:56 [PULL 00/18] s390x and misc patches Thomas Huth
2023-06-06 5:56 ` [PULL 01/18] target/s390x: Fix LCBB overwriting the top 32 bits Thomas Huth
2023-06-06 5:56 ` [PULL 02/18] tests/tcg/s390x: Test LCBB Thomas Huth
2023-06-06 5:56 ` Thomas Huth [this message]
2023-06-06 5:56 ` [PULL 04/18] tests/tcg/s390x: Test LOCFHR Thomas Huth
2023-06-06 5:56 ` [PULL 05/18] linux-user/s390x: Fix single-stepping SVC Thomas Huth
2023-06-06 5:56 ` [PULL 06/18] tests/tcg/s390x: Test " Thomas Huth
2023-06-06 5:56 ` [PULL 07/18] Add conditional dependency for libkeyutils Thomas Huth
2023-06-06 5:56 ` [PULL 08/18] target/s390x: Fix MXDB and MXDBR Thomas Huth
2023-06-06 5:56 ` [PULL 09/18] tests/tcg/s390x: Test " Thomas Huth
2023-06-06 5:56 ` [PULL 10/18] tests/qtest: Run ipmi-bt-test only if CONFIG_IPMI_EXTERN is set Thomas Huth
2023-06-06 5:56 ` [PULL 11/18] gitlab-ci: Remove unused Python package Thomas Huth
2023-06-06 5:56 ` [PULL 12/18] hw/mips/malta: Fix the malta machine on big endian hosts Thomas Huth
2023-06-06 5:56 ` [PULL 13/18] scripts: Add qom-cast-macro-clean-cocci-gen.py Thomas Huth
2023-06-06 5:56 ` [PULL 14/18] bulk: Remove pointless QOM casts Thomas Huth
2023-06-06 5:56 ` [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP Thomas Huth
2023-06-07 9:05 ` Michael Tokarev
2023-06-07 9:11 ` Ilya Leoshkevich
2023-06-06 5:56 ` [PULL 16/18] linux-user/elfload: Expose get_elf_hwcap() on s390x Thomas Huth
2023-06-06 5:56 ` [PULL 17/18] linux-user/elfload: Introduce elf_hwcap_str() " Thomas Huth
2023-06-06 5:56 ` [PULL 18/18] linux-user: Emulate /proc/cpuinfo " Thomas Huth
2023-06-06 15:46 ` [PULL 00/18] s390x and misc patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606055621.523175-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=mitskevichmn@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).