From: Igor Mammedov <imammedo@redhat.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: <qemu-devel@nongnu.org>, <pbonzini@redhat.com>,
<richard.henderson@linaro.org>, <eduardo@habkost.net>,
<mst@redhat.com>, <marcel.apfelbaum@gmail.com>,
<berrange@redhat.com>, <jusual@redhat.com>, <dfaggioli@suse.com>,
<joao.m.martins@oracle.com>, <jon.grimm@amd.com>,
<santosh.Shukla@amd.com>
Subject: Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models
Date: Tue, 6 Jun 2023 10:11:24 +0200 [thread overview]
Message-ID: <20230606101124.7d252fae@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20230606093541.5a2e6b87@imammedo.users.ipa.redhat.com>
On Tue, 6 Jun 2023 09:35:41 +0200
Igor Mammedov <imammedo@redhat.com> wrote:
> On Mon, 5 Jun 2023 16:39:05 -0500
> Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> wrote:
[...]
> > + /* For pc-i44fx-8.0 and older, use SMBIOS 2.8 by default */
> > + pcmc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_32;
> > }
[...]
> > static void pc_q35_8_0_machine_options(MachineClass *m)
> > {
[...]
> > + /* For pc-q35-8.0 and older, use SMBIOS 2.8 by default */
> > + pcmc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_32;
> > }
[...]
what Michael referred to as duplication is probably these lines,
however "smbios-entry-point-type: is machine property so we can't
use device compat machinery here (pc_compat_8_0).
What we can do is override "default_machine_opts" value, but then
again it has to be opencoded in piix4/q35_machine_options, so
don't see a point in doing so.
As you wrote here is what typically do for machine compat knobs,
so it should be fine.
I just doubt that we need extra default_smbios_ep_type field.
next prev parent reply other threads:[~2023-06-06 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 21:39 [PATCH v4 0/3] hw/i386/pc: Update max_cpus and default to SMBIOS Suravee Suthikulpanit
2023-06-05 21:39 ` [PATCH v4 1/3] hw/i386/pc: Refactor logic to set SMBIOS set defaults Suravee Suthikulpanit
2023-06-06 7:45 ` Igor Mammedov
2023-06-07 1:23 ` Suthikulpanit, Suravee
2023-06-05 21:39 ` [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models Suravee Suthikulpanit
2023-06-06 7:35 ` Igor Mammedov
2023-06-06 8:11 ` Igor Mammedov [this message]
2023-06-07 1:46 ` Suthikulpanit, Suravee
2023-06-07 1:25 ` Suthikulpanit, Suravee
2023-06-05 21:39 ` [PATCH v4 3/3] pc: q35: Bump max_cpus to 1024 Suravee Suthikulpanit
2023-06-06 7:55 ` Igor Mammedov
2023-06-07 1:19 ` Suthikulpanit, Suravee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606101124.7d252fae@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=berrange@redhat.com \
--cc=dfaggioli@suse.com \
--cc=eduardo@habkost.net \
--cc=joao.m.martins@oracle.com \
--cc=jon.grimm@amd.com \
--cc=jusual@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=santosh.Shukla@amd.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).