qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Shaoqin Huang <shahuang@redhat.com>
Cc: qemu-devel@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH] hw: Fix format for comments
Date: Tue, 6 Jun 2023 15:29:49 +0200	[thread overview]
Message-ID: <20230606152949.1aad469e@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20230515072525.886221-1-shahuang@redhat.com>

On Mon, 15 May 2023 03:25:25 -0400
Shaoqin Huang <shahuang@redhat.com> wrote:

> Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments.

> Since
> we are at here, resort the parameters in comments to match the sequence
While at it, reorder ...
                   
> of parameters which defined in the CPUArchId.
> 
> CC: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>

with commit message fixed up
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  include/hw/boards.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index f4117fdb9a..cefa3d5897 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
>  /**
>   * CPUArchId:
>   * @arch_id - architecture-dependent CPU ID of present or possible CPU
> + * @vcpus_count - number of threads provided by @cpu object
> + * @props - CPU object properties, initialized by board
>   * @cpu - pointer to corresponding CPU object if it's present on NULL otherwise
>   * @type - QOM class name of possible @cpu object
> - * @props - CPU object properties, initialized by board
> - * #vcpus_count - number of threads provided by @cpu object
>   */
>  typedef struct CPUArchId {
>      uint64_t arch_id;



  reply	other threads:[~2023-06-06 13:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15  7:25 [PATCH] hw: Fix format for comments Shaoqin Huang
2023-06-06 13:29 ` Igor Mammedov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-05  7:23 Shaoqin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230606152949.1aad469e@imammedo.users.ipa.redhat.com \
    --to=imammedo@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shahuang@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).