From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-ppc@nongnu.org, "Beraldo Leal" <bleal@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Kautuk Consul" <kconsul@linux.vnet.ibm.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>
Subject: [PATCH] tests/avocado/tuxrun_baselines: Fix ppc64 tests for binaries without slirp
Date: Tue, 6 Jun 2023 21:28:02 +0200 [thread overview]
Message-ID: <20230606192802.666000-1-thuth@redhat.com> (raw)
The ppc64 tuxrun tests are currently failing if "slirp" has been
disabled in the binary since they are using "-netdev user" now.
We have to skip the test if this network backend is missing.
Fixes: 6ee3624236 ("improve code coverage for ppc64")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/avocado/tuxrun_baselines.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/avocado/tuxrun_baselines.py b/tests/avocado/tuxrun_baselines.py
index 3a46e7a745..e12250eabb 100644
--- a/tests/avocado/tuxrun_baselines.py
+++ b/tests/avocado/tuxrun_baselines.py
@@ -184,6 +184,7 @@ def common_tuxrun(self,
def ppc64_common_tuxrun(self, sums, prefix):
# add device args to command line.
+ self.require_netdev('user')
self.vm.add_args('-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22',
'-device', 'virtio-net,netdev=vnet')
self.vm.add_args('-netdev', '{"type":"user","id":"hostnet0"}',
--
2.31.1
next reply other threads:[~2023-06-06 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 19:28 Thomas Huth [this message]
2023-06-06 19:35 ` [PATCH] tests/avocado/tuxrun_baselines: Fix ppc64 tests for binaries without slirp Philippe Mathieu-Daudé
2023-06-06 20:16 ` Daniel Henrique Barboza
2023-06-07 4:22 ` Joel Stanley
2023-06-07 7:40 ` Thomas Huth
2023-06-07 12:49 ` Daniel Henrique Barboza
2023-06-07 14:08 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606192802.666000-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=kconsul@linux.vnet.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).