From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A8ACC7EE23 for ; Wed, 7 Jun 2023 12:32:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6sJW-0002RH-Ie; Wed, 07 Jun 2023 08:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6sJS-0002NY-Du for qemu-devel@nongnu.org; Wed, 07 Jun 2023 08:30:55 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6sJO-0006bd-8j for qemu-devel@nongnu.org; Wed, 07 Jun 2023 08:30:53 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-977c88c9021so700762966b.3 for ; Wed, 07 Jun 2023 05:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1686141046; x=1688733046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2hbmIiL4qojzHftVNMGlqJxGnJ4NGjH6PMKCzdLAjTA=; b=dckDy1pW+o8G0tpq4c7rw6HmqsjgqTz9YGRITsXVgvXAVc3WEjCaq3NRBJevSnTuPW YrbFut340BqgmhuLDEk2VQ1nHUqIsfKc6Xba/kkUnyLPJWAW3T8/HSqE16UUPteudI5l OP7nAPGfB9oiKQzsmnrAviPmf0RJpCEq9bPeQ1Zw2i1aeFFSznmaZTGg6cA9BOOLAI11 yqrv3Neg3zBlU/d32MUbW9CCjFmzNo1LNugMpnPLNF3TNR0/h3Ug61lJ9v/95pk89sJJ nijc+myjocsq2Pe9XdvBr6PbFuVNtUNqXPuNFG4UfZoyR6+gRqtIKnHTN+CLOJj4u/Wy apmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686141046; x=1688733046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2hbmIiL4qojzHftVNMGlqJxGnJ4NGjH6PMKCzdLAjTA=; b=DHzj2FUDXqTMoHNvUucIrCV6EnZbcptJjWOALxvPiVIonF7i65fPXFQ7vqDfHlxlJj UZH8RfqyezUhSwcOvbWFHpb7PLBg3P9MMFW5GSd9s5CM4o6ioYVwfoMeD+1KHzHrPP1M ucxF/Dn7ctXbpiXCOmBTJgQCzfOGUc+qFdUdM8D8CBQ31u0yjSm9rZm2szPvOSIz0ypJ 8a9Ia+FGZjW5MXKt0ZnGR/VzCmrrrT5L/JGm8SwD1pDthg5j1tizXeqfXztIScJBDXQM /8F9iwrdZWzpNTJSTZ9AgspUi3vsd4ZpeMyEpjRNlM+mXOrsaqOroymvnIyZZ17Yo7VK d9Kw== X-Gm-Message-State: AC+VfDxIhtrN7bNpnPxU9LkuzL1Cl8dgCG1u2mvPS+3QHee1X3gG/0Zv c+6BrBxyCsaARATd2M/dWhI9DSeCBRyrC4iYnm8= X-Google-Smtp-Source: ACHHUZ69r35ZFnYhkRGbfSxzZqjWfhVN7FOXceilZZg5E4bqToHiMcgvaOv3WLJvMUzpaQjOudaoNg== X-Received: by 2002:a17:907:6d83:b0:977:cbaf:bc56 with SMTP id sb3-20020a1709076d8300b00977cbafbc56mr6437946ejc.43.1686141046540; Wed, 07 Jun 2023 05:30:46 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id v13-20020a17090606cd00b00977da0f14ffsm3970301ejb.171.2023.06.07.05.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 05:30:45 -0700 (PDT) Date: Wed, 7 Jun 2023 14:30:44 +0200 From: Andrew Jones To: Daniel Henrique Barboza Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com Subject: Re: [PATCH 15/16] target/riscv: update multi-letter extension KVM properties Message-ID: <20230607-9a3e536ad70720dd791c7e83@orel> References: <20230530194623.272652-1-dbarboza@ventanamicro.com> <20230530194623.272652-16-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530194623.272652-16-dbarboza@ventanamicro.com> Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=ajones@ventanamicro.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, May 30, 2023 at 04:46:22PM -0300, Daniel Henrique Barboza wrote: > We're now ready to update the multi-letter extensions status for KVM. > > kvm_riscv_update_cpu_cfg_isa_ext() is called called during vcpu creation > time to verify which user options changes host defaults (via the 'user_set' > flag) and tries to write them back to KVM. > > Failure to commit a change to KVM is only ignored in case KVM doesn't > know about the extension (-EINVAL error code) and the user wanted to > disable the given extension. Otherwise we're going to abort the boot > process. > > Signed-off-by: Daniel Henrique Barboza > --- > target/riscv/kvm.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c > index 675e18df3b..92b99fe261 100644 > --- a/target/riscv/kvm.c > +++ b/target/riscv/kvm.c > @@ -295,6 +295,32 @@ static void kvm_cpu_set_multi_ext_cfg(Object *obj, Visitor *v, > kvm_cpu_cfg_set(cpu, multi_ext_cfg, value); > } > > +static void kvm_riscv_update_cpu_cfg_isa_ext(RISCVCPU *cpu, CPUState *cs) > +{ > + CPURISCVState *env = &cpu->env; > + uint64_t id, reg; > + int i, ret; > + > + for (i = 0; i < ARRAY_SIZE(kvm_multi_ext_cfgs); i++) { > + RISCVCPUMultiExtConfig *multi_ext_cfg = &kvm_multi_ext_cfgs[i]; > + > + if (!multi_ext_cfg->user_set) { > + continue; > + } > + > + id = kvm_riscv_reg_id(env, KVM_REG_RISCV_ISA_EXT, > + multi_ext_cfg->kvm_reg_id); > + reg = kvm_cpu_cfg_get(cpu, multi_ext_cfg); > + ret = kvm_set_one_reg(cs, id, ®); > + if (ret != 0) { > + error_report("Unable to %s extension %s in KVM, error %d", > + reg ? "enable" : "disable", > + multi_ext_cfg->name, ret); > + exit(EXIT_FAILURE); > + } > + } > +} > + > static void kvm_riscv_add_cpu_user_properties(Object *cpu_obj) > { > int i; > @@ -829,6 +855,7 @@ int kvm_arch_init_vcpu(CPUState *cs) > } > > kvm_riscv_update_cpu_misa_ext(cpu, cs); > + kvm_riscv_update_cpu_cfg_isa_ext(cpu, cs); > > return ret; > } > -- > 2.40.1 > > Reviewed-by: Andrew Jones