qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Erico Nunes <ernunes@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, mst@redhat.com, kraxel@redhat.com,
	Erico Nunes <ernunes@redhat.com>
Subject: [PATCH v3 0/4] vhost-user-gpu get_edid feature
Date: Wed,  7 Jun 2023 16:54:51 +0200	[thread overview]
Message-ID: <20230607145455.158267-1-ernunes@redhat.com> (raw)

This adds support to the virtio-gpu get_edid command in qemu as the
frontend as well as the vhost-user-gpu implementation in contrib/.
So far, qemu has been outputting the following message:
  EDID requested but the backend doesn't support it.
when using that implementation.

This is tested with vhost-user-gpu, the dbus ui backend and the
monitor-edid application, which now shows complete "QEMU Monitor" edid
data.

The VHOST_USER_GPU_PROTOCOL_F_EDID protocol feature is required if the
frontend sets the VIRTIO_GPU_F_EDID virtio-gpu feature. If the frontend
sets the virtio-gpu feature but does not support the protocol feature,
the backend will abort with an error.

v2 -> v3:
- Fixed review comments from v2. Missing struct documentation and
setting feature bits to be compatible with the frontend.

Erico Nunes (4):
  virtio-gpu: refactor generate_edid function to virtio_gpu_base
  docs: vhost-user-gpu: add protocol changes for EDID
  contrib/vhost-user-gpu: implement get_edid feature
  vhost-user-gpu: implement get_edid frontend feature

 contrib/vhost-user-gpu/vhost-user-gpu.c | 73 +++++++++++++++++++++++--
 contrib/vhost-user-gpu/virgl.c          |  3 +
 contrib/vhost-user-gpu/vugpu.h          | 11 ++++
 docs/interop/vhost-user-gpu.rst         | 28 +++++++++-
 hw/display/vhost-user-gpu.c             | 36 ++++++++++++
 hw/display/virtio-gpu-base.c            | 17 ++++++
 hw/display/virtio-gpu.c                 | 20 +------
 include/hw/virtio/virtio-gpu.h          |  2 +
 8 files changed, 162 insertions(+), 28 deletions(-)

-- 
2.40.1



             reply	other threads:[~2023-06-07 14:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 14:54 Erico Nunes [this message]
2023-06-07 14:54 ` [PATCH v3 1/4] virtio-gpu: refactor generate_edid function to virtio_gpu_base Erico Nunes
2023-06-07 14:54 ` [PATCH v3 2/4] docs: vhost-user-gpu: add protocol changes for EDID Erico Nunes
2023-06-07 14:54 ` [PATCH v3 3/4] contrib/vhost-user-gpu: implement get_edid feature Erico Nunes
2023-06-07 14:54 ` [PATCH v3 4/4] vhost-user-gpu: implement get_edid frontend feature Erico Nunes
2023-06-12 10:31   ` Marc-André Lureau
2023-06-12 10:32 ` [PATCH v3 0/4] vhost-user-gpu get_edid feature Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607145455.158267-1-ernunes@redhat.com \
    --to=ernunes@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).