qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, eperezma@redhat.com
Cc: qemu-devel@nongnu.org, Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH] vdpa: dont check vhost_vdpa->suspended when unsupported
Date: Thu,  8 Jun 2023 01:08:42 +0800	[thread overview]
Message-ID: <20230607170842.488489-1-lingshan.zhu@intel.com> (raw)

When read the state of a virtqueue, vhost_vdpa need
to check whether the device is suspended.

This commit verifies whether VHOST_BACKEND_F_SUSPEND is
negotiated when checking vhost_vdpa->suspended.

Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
 hw/virtio/vhost-vdpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index b3094e8a8b..ae176c06dd 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1397,7 +1397,7 @@ static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
         return 0;
     }
 
-    if (!v->suspended) {
+    if ((dev->backend_cap & BIT_ULL(VHOST_BACKEND_F_SUSPEND)) && (!v->suspended)) {
         /*
          * Cannot trust in value returned by device, let vhost recover used
          * idx from guest.
-- 
2.39.1



             reply	other threads:[~2023-06-07  9:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 17:08 Zhu Lingshan [this message]
2023-06-07 13:51 ` [PATCH] vdpa: dont check vhost_vdpa->suspended when unsupported Eugenio Perez Martin
2023-06-08  7:07   ` Zhu, Lingshan
2023-06-08  8:49     ` Eugenio Perez Martin
2023-06-08  9:34       ` Zhu, Lingshan
2023-06-08 10:59         ` Eugenio Perez Martin
2023-06-08 13:19           ` Zhu, Lingshan
2023-06-08 14:38             ` Eugenio Perez Martin
2023-06-09  3:13   ` Jason Wang
2023-06-09  8:49     ` Zhu, Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607170842.488489-1-lingshan.zhu@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).