From: Martin Kaiser <martin@kaiser.cx>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH] imx_serial: set wake bit when we receive a data byte
Date: Thu, 8 Jun 2023 16:41:29 +0100 [thread overview]
Message-ID: <20230608154129.133169-1-martin@kaiser.cx> (raw)
The linux kernel added a flood check for rx data recently in commmit
496a4471b7c3 ("serial: imx: work-around for hardware RX flood"). This
check uses the wake bit in the uart status register 2. The wake bit
indicates that the receiver detected a start bit. If the kernel sees a
number of rx interrupts without the wake bit being set, it treats this as
spurious data and resets the uart port. imx_serial does never set the
wake bit and triggers the kernel's flood check.
This patch adds support for the wake bit. wake is set when we receive a
new character (it's not set for break events). It seems that wake is
cleared by the kernel driver, the hardware does not have to clear it
automatically after data was read.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
hw/char/imx_serial.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c
index ee1375e26d..44125d5f47 100644
--- a/hw/char/imx_serial.c
+++ b/hw/char/imx_serial.c
@@ -321,6 +321,9 @@ static void imx_put_data(void *opaque, uint32_t value)
static void imx_receive(void *opaque, const uint8_t *buf, int size)
{
+ IMXSerialState *s = (IMXSerialState *)opaque;
+
+ s->usr2 |= USR2_WAKE;
imx_put_data(opaque, *buf);
}
--
2.30.2
next reply other threads:[~2023-06-08 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 15:41 Martin Kaiser [this message]
2023-06-12 13:23 ` [PATCH] imx_serial: set wake bit when we receive a data byte Philippe Mathieu-Daudé
2023-06-15 9:27 ` Martin Kaiser
2023-06-15 9:30 ` [PATCH v2] " Martin Kaiser
2023-06-15 10:25 ` Philippe Mathieu-Daudé
2023-06-15 14:22 ` [PATCH v3] " Martin Kaiser
2023-06-19 10:36 ` Peter Maydell
2023-06-19 13:09 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608154129.133169-1-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).