From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: ardb@kernel.org, berrange@redhat.com, qemu-ppc@nongnu.org,
qemu-arm@nongnu.org, qemu-riscv@nongnu.org, pbonzini@redhat.com
Subject: [PATCH v2 00/38] crypto: Provide aes-round.h and host accel
Date: Thu, 8 Jun 2023 19:23:23 -0700 [thread overview]
Message-ID: <20230609022401.684157-1-richard.henderson@linaro.org> (raw)
Inspired by Ard Biesheuvel's RFC patches for accelerating AES
under emulation, provide a set of primitives that maps between
the guest and host fragments.
There is a small guest correctness test case.
I think the end result is quite a bit cleaner, since the logic
is now centralized, rather than spread across 4 different guests.
Further work could clean up crypto/aes.c itself to use these
instead of the tables directly. I'm sure that's just an ultimate
fallback when an appropriate system library is not available, and
so not terribly important, but it could still significantly reduce
the amount of code we carry.
I would imagine structuring a polynomial multiplication header
in a similar way. There are 4 or 5 versions of those spread across
the different guests.
Changes for v2:
* Change aesenc_SB_SR -> aesenc_SB_SR_AK
* Change aesdec_ISB_ISR -> aesdec_ISB_ISR_AK
Both of these because if we have to provide a zero to x86 and ppc
hosts, we can do that at the guest level just as easily as the host.
Which allows x86 and ppc guests to provide the key their key.
* Add aesdec_ISB_ISR_AK_IMC
Provide a variation for the Power8 primitive. Easy enough to do
with two x86 instructions.
* Add ppc host support.
Nasty issues with <altivec.h>, fighting with builtins vs bswap,
so everything is in inline asm.
r~
Richard Henderson (38):
tcg/ppc: Define _CALL_AIX for clang on ppc64(be)
util: Add cpuinfo-ppc.c
tests/multiarch: Add test-aes
target/arm: Move aesmc and aesimc tables to crypto/aes.c
crypto/aes: Add constants for ShiftRows, InvShiftRows
crypto: Add aesenc_SB_SR_AK
target/i386: Use aesenc_SB_SR_AK
target/arm: Demultiplex AESE and AESMC
target/arm: Use aesenc_SB_SR_AK
target/ppc: Use aesenc_SB_SR_AK
target/riscv: Use aesenc_SB_SR_AK
crypto: Add aesdec_ISB_ISR_AK
target/i386: Use aesdec_ISB_ISR_AK
target/arm: Use aesdec_ISB_ISR_AK
target/ppc: Use aesdec_ISB_ISR_AK
target/riscv: Use aesdec_ISB_ISR_AK
crypto: Add aesenc_MC
target/arm: Use aesenc_MC
crypto: Add aesdec_IMC
target/i386: Use aesdec_IMC
target/arm: Use aesdec_IMC
target/riscv: Use aesdec_IMC
crypto: Add aesenc_SB_SR_MC_AK
target/i386: Use aesenc_SB_SR_MC_AK
target/ppc: Use aesenc_SB_SR_MC_AK
target/riscv: Use aesenc_SB_SR_MC_AK
crypto: Add aesdec_ISB_ISR_IMC_AK
target/i386: Use aesdec_ISB_ISR_IMC_AK
target/riscv: Use aesdec_ISB_ISR_IMC_AK
crypto: Add aesdec_ISB_ISR_AK_IMC
target/ppc: Use aesdec_ISB_ISR_AK_IMC
crypto: Remove AES_shifts, AES_ishifts
crypto: Implement aesdec_IMC with AES_imc_rot
crypto: Remove AES_imc
crypto: Unexport AES_*_rot, AES_TeN, AES_TdN
host/include/i386: Implement aes-round.h
host/include/aarch64: Implement aes-round.h
host/include/ppc: Implement aes-round.h
meson.build | 9 +
host/include/aarch64/host/aes-round.h | 205 ++++++
host/include/aarch64/host/cpuinfo.h | 1 +
host/include/generic/host/aes-round.h | 33 +
host/include/i386/host/aes-round.h | 152 +++++
host/include/i386/host/cpuinfo.h | 1 +
host/include/ppc/host/aes-round.h | 181 ++++++
host/include/ppc/host/cpuinfo.h | 30 +
host/include/ppc64/host/aes-round.h | 1 +
host/include/ppc64/host/cpuinfo.h | 1 +
host/include/x86_64/host/aes-round.h | 1 +
include/crypto/aes-round.h | 164 +++++
include/crypto/aes.h | 30 -
target/arm/helper.h | 2 +
target/i386/ops_sse.h | 60 +-
tcg/ppc/tcg-target.h | 16 +-
target/arm/tcg/sve.decode | 4 +-
crypto/aes.c | 796 ++++++++++++++++--------
target/arm/tcg/crypto_helper.c | 249 +++-----
target/arm/tcg/translate-a64.c | 13 +-
target/arm/tcg/translate-neon.c | 4 +-
target/arm/tcg/translate-sve.c | 8 +-
target/ppc/int_helper.c | 50 +-
target/riscv/crypto_helper.c | 138 ++--
tests/tcg/aarch64/test-aes.c | 58 ++
tests/tcg/i386/test-aes.c | 68 ++
tests/tcg/ppc64/test-aes.c | 116 ++++
tests/tcg/riscv64/test-aes.c | 76 +++
util/cpuinfo-aarch64.c | 2 +
util/cpuinfo-i386.c | 3 +
util/cpuinfo-ppc.c | 65 ++
tcg/ppc/tcg-target.c.inc | 67 +-
tests/tcg/multiarch/test-aes-main.c.inc | 183 ++++++
tests/tcg/aarch64/Makefile.target | 4 +
tests/tcg/i386/Makefile.target | 4 +
tests/tcg/ppc64/Makefile.target | 1 +
tests/tcg/riscv64/Makefile.target | 4 +
util/meson.build | 2 +
38 files changed, 2074 insertions(+), 728 deletions(-)
create mode 100644 host/include/aarch64/host/aes-round.h
create mode 100644 host/include/generic/host/aes-round.h
create mode 100644 host/include/i386/host/aes-round.h
create mode 100644 host/include/ppc/host/aes-round.h
create mode 100644 host/include/ppc/host/cpuinfo.h
create mode 100644 host/include/ppc64/host/aes-round.h
create mode 100644 host/include/ppc64/host/cpuinfo.h
create mode 100644 host/include/x86_64/host/aes-round.h
create mode 100644 include/crypto/aes-round.h
create mode 100644 tests/tcg/aarch64/test-aes.c
create mode 100644 tests/tcg/i386/test-aes.c
create mode 100644 tests/tcg/ppc64/test-aes.c
create mode 100644 tests/tcg/riscv64/test-aes.c
create mode 100644 util/cpuinfo-ppc.c
create mode 100644 tests/tcg/multiarch/test-aes-main.c.inc
--
2.34.1
next reply other threads:[~2023-06-09 2:25 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 2:23 Richard Henderson [this message]
2023-06-09 2:23 ` [PATCH v2 01/38] tcg/ppc: Define _CALL_AIX for clang on ppc64(be) Richard Henderson
2023-06-12 13:25 ` Daniel Henrique Barboza
2023-06-09 2:23 ` [PATCH v2 02/38] util: Add cpuinfo-ppc.c Richard Henderson
2023-06-12 13:27 ` Daniel Henrique Barboza
2023-06-19 10:37 ` Philippe Mathieu-Daudé
2023-06-19 14:44 ` Richard Henderson
2023-06-09 2:23 ` [PATCH v2 03/38] tests/multiarch: Add test-aes Richard Henderson
2023-06-12 14:46 ` Alex Bennée
2023-06-14 3:40 ` Richard Henderson
2023-06-09 2:23 ` [PATCH v2 04/38] target/arm: Move aesmc and aesimc tables to crypto/aes.c Richard Henderson
2023-06-19 16:49 ` Daniel P. Berrangé
2023-06-09 2:23 ` [PATCH v2 05/38] crypto/aes: Add constants for ShiftRows, InvShiftRows Richard Henderson
2023-06-19 15:41 ` Daniel P. Berrangé
2023-06-29 10:21 ` Ard Biesheuvel
2023-06-29 11:58 ` Richard Henderson
2023-06-09 2:23 ` [PATCH v2 06/38] crypto: Add aesenc_SB_SR_AK Richard Henderson
2023-06-19 16:56 ` Daniel P. Berrangé
2023-06-19 17:05 ` Richard Henderson
2023-06-09 2:23 ` [PATCH v2 07/38] target/i386: Use aesenc_SB_SR_AK Richard Henderson
2023-06-19 10:43 ` Philippe Mathieu-Daudé
2023-06-19 10:45 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 08/38] target/arm: Demultiplex AESE and AESMC Richard Henderson
2023-06-09 2:23 ` [PATCH v2 09/38] target/arm: Use aesenc_SB_SR_AK Richard Henderson
2023-06-09 2:23 ` [PATCH v2 10/38] target/ppc: " Richard Henderson
2023-06-12 13:26 ` Daniel Henrique Barboza
2023-06-19 10:47 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 11/38] target/riscv: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 12/38] crypto: Add aesdec_ISB_ISR_AK Richard Henderson
2023-06-09 2:23 ` [PATCH v2 13/38] target/i386: Use aesdec_ISB_ISR_AK Richard Henderson
2023-06-19 10:51 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 14/38] target/arm: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 15/38] target/ppc: " Richard Henderson
2023-06-12 13:27 ` Daniel Henrique Barboza
2023-06-19 10:51 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 16/38] target/riscv: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 17/38] crypto: Add aesenc_MC Richard Henderson
2023-06-09 2:23 ` [PATCH v2 18/38] target/arm: Use aesenc_MC Richard Henderson
2023-06-09 2:23 ` [PATCH v2 19/38] crypto: Add aesdec_IMC Richard Henderson
2023-06-09 2:23 ` [PATCH v2 20/38] target/i386: Use aesdec_IMC Richard Henderson
2023-06-09 2:23 ` [PATCH v2 21/38] target/arm: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 22/38] target/riscv: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 23/38] crypto: Add aesenc_SB_SR_MC_AK Richard Henderson
2023-06-09 2:23 ` [PATCH v2 24/38] target/i386: Use aesenc_SB_SR_MC_AK Richard Henderson
2023-06-09 2:23 ` [PATCH v2 25/38] target/ppc: " Richard Henderson
2023-06-12 13:28 ` Daniel Henrique Barboza
2023-06-09 2:23 ` [PATCH v2 26/38] target/riscv: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 27/38] crypto: Add aesdec_ISB_ISR_IMC_AK Richard Henderson
2023-06-09 2:23 ` [PATCH v2 28/38] target/i386: Use aesdec_ISB_ISR_IMC_AK Richard Henderson
2023-06-09 2:23 ` [PATCH v2 29/38] target/riscv: " Richard Henderson
2023-06-09 2:23 ` [PATCH v2 30/38] crypto: Add aesdec_ISB_ISR_AK_IMC Richard Henderson
2023-06-19 13:59 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 31/38] target/ppc: Use aesdec_ISB_ISR_AK_IMC Richard Henderson
2023-06-12 13:28 ` Daniel Henrique Barboza
2023-06-19 13:46 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 32/38] crypto: Remove AES_shifts, AES_ishifts Richard Henderson
2023-06-19 13:45 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 33/38] crypto: Implement aesdec_IMC with AES_imc_rot Richard Henderson
2023-06-20 5:09 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 34/38] crypto: Remove AES_imc Richard Henderson
2023-06-19 13:19 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 35/38] crypto: Unexport AES_*_rot, AES_TeN, AES_TdN Richard Henderson
2023-06-19 13:18 ` Philippe Mathieu-Daudé
2023-06-09 2:23 ` [PATCH v2 36/38] host/include/i386: Implement aes-round.h Richard Henderson
2023-06-09 2:24 ` [PATCH v2 37/38] host/include/aarch64: " Richard Henderson
2023-06-09 2:24 ` [PATCH v2 38/38] host/include/ppc: " Richard Henderson
2023-06-12 13:30 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609022401.684157-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ardb@kernel.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).