* [PATCH] hw/i386/pc: Clean up pc_machine_initfn
@ 2023-06-09 16:41 Suravee Suthikulpanit
2023-06-09 21:57 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Suravee Suthikulpanit @ 2023-06-09 16:41 UTC (permalink / raw)
To: qemu-devel
Cc: mst, marcel.apfelbaum, imammedo, jon.grimm, santosh.Shukla,
Suravee Suthikulpanit
To use the newly introduced PC machine class local variable.
Suggedted-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
---
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 33ffb03a32..f8d105e829 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1864,7 +1864,7 @@ static void pc_machine_initfn(Object *obj)
pcms->smbios_entry_point_type = pcmc->default_smbios_ep_type;
/* acpi build is enabled by default if machine supports it */
- pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
+ pcms->acpi_build_enabled = pcmc->has_acpi_build;
pcms->smbus_enabled = true;
pcms->sata_enabled = true;
pcms->i8042_enabled = true;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/i386/pc: Clean up pc_machine_initfn
2023-06-09 16:41 [PATCH] hw/i386/pc: Clean up pc_machine_initfn Suravee Suthikulpanit
@ 2023-06-09 21:57 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-09 21:57 UTC (permalink / raw)
To: Suravee Suthikulpanit, qemu-devel
Cc: mst, marcel.apfelbaum, imammedo, jon.grimm, santosh.Shukla
On 9/6/23 18:41, Suravee Suthikulpanit wrote:
> To use the newly introduced PC machine class local variable.
>
> Suggedted-by: Igor Mammedov <imammedo@redhat.com>
"Suggested-by"
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
> hw/i386/pc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 33ffb03a32..f8d105e829 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1864,7 +1864,7 @@ static void pc_machine_initfn(Object *obj)
> pcms->smbios_entry_point_type = pcmc->default_smbios_ep_type;
>
> /* acpi build is enabled by default if machine supports it */
> - pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
> + pcms->acpi_build_enabled = pcmc->has_acpi_build;
> pcms->smbus_enabled = true;
> pcms->sata_enabled = true;
> pcms->i8042_enabled = true;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-09 21:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 16:41 [PATCH] hw/i386/pc: Clean up pc_machine_initfn Suravee Suthikulpanit
2023-06-09 21:57 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).