From: Stefano Stabellini <sstabellini@kernel.org>
To: peter.maydell@linaro.org, richard.henderson@linaro.org
Cc: sstabellini@kernel.org, qemu-devel@nongnu.org,
vikram.garhwal@amd.com,
Stefano Stabellini <stefano.stabellini@amd.com>,
Paul Durrant <paul@xen.org>
Subject: [PULL v5 05/11] include/hw/xen/xen_common: return error from xen_create_ioreq_server
Date: Thu, 15 Jun 2023 16:52:48 -0700 [thread overview]
Message-ID: <20230615235254.1366267-5-sstabellini@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2306151649350.897208@ubuntu-linux-20-04-desktop>
From: Stefano Stabellini <stefano.stabellini@amd.com>
This is done to prepare for enabling xenpv support for ARM architecture.
On ARM it is possible to have a functioning xenpv machine with only the
PV backends and no IOREQ server. If the IOREQ server creation fails,
continue to the PV backends initialization.
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Signed-off-by: Vikram Garhwal <vikram.garhwal@amd.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Paul Durrant <paul@xen.org>
---
include/hw/xen/xen_native.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h
index f11eb423e3..4dce905fde 100644
--- a/include/hw/xen/xen_native.h
+++ b/include/hw/xen/xen_native.h
@@ -463,8 +463,8 @@ static inline void xen_unmap_pcidev(domid_t dom,
PCI_FUNC(pci_dev->devfn));
}
-static inline void xen_create_ioreq_server(domid_t dom,
- ioservid_t *ioservid)
+static inline int xen_create_ioreq_server(domid_t dom,
+ ioservid_t *ioservid)
{
int rc = xendevicemodel_create_ioreq_server(xen_dmod, dom,
HVM_IOREQSRV_BUFIOREQ_ATOMIC,
@@ -472,12 +472,14 @@ static inline void xen_create_ioreq_server(domid_t dom,
if (rc == 0) {
trace_xen_ioreq_server_create(*ioservid);
- return;
+ return rc;
}
*ioservid = 0;
use_default_ioreq_server = true;
trace_xen_default_ioreq_server();
+
+ return rc;
}
static inline void xen_destroy_ioreq_server(domid_t dom,
--
2.25.1
next prev parent reply other threads:[~2023-06-15 23:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 23:52 [PULL v5 00/11] xenpvh5-tag Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 01/11] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 02/11] hw/i386/xen: rearrange xen_hvm_init_pc Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 03/11] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 04/11] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common Stefano Stabellini
2023-06-15 23:52 ` Stefano Stabellini [this message]
2023-06-15 23:52 ` [PULL v5 06/11] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Stefano Stabellini
2023-06-20 10:40 ` Peter Maydell
2023-06-15 23:52 ` [PULL v5 07/11] hw/xen/xen-hvm-common: Use g_new and error_report Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 08/11] meson.build: do not set have_xen_pci_passthrough for aarch64 targets Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 09/11] hw/arm: introduce xenpvh machine Stefano Stabellini
2025-03-05 11:36 ` Philippe Mathieu-Daudé
2025-03-05 23:20 ` Stefano Stabellini
2025-03-06 0:13 ` Edgar E. Iglesias
2025-03-06 6:28 ` Philippe Mathieu-Daudé
2023-06-15 23:52 ` [PULL v5 10/11] meson.build: enable xenpv machine build for ARM Stefano Stabellini
2023-06-15 23:52 ` [PULL v5 11/11] test/qtest: add xepvh to skip list for qtest Stefano Stabellini
2023-06-17 8:02 ` [PULL v5 00/11] xenpvh5-tag Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615235254.1366267-5-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefano.stabellini@amd.com \
--cc=vikram.garhwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).