From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: qemu-devel@nongnu.org
Cc: kbastian@mail.uni-paderborn.de, richard.henderson@linaro.org
Subject: [PATCH v2 1/8] target/tricore: Fix RR_JLI clobbering reg A[11]
Date: Fri, 16 Jun 2023 17:28:01 +0200 [thread overview]
Message-ID: <20230616152808.1499082-2-kbastian@mail.uni-paderborn.de> (raw)
In-Reply-To: <20230616152808.1499082-1-kbastian@mail.uni-paderborn.de>
if A[r1] == A[11], then we would overwrite the destination address of
the jump with the return address.
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 6712d98f6e..1d522d3b50 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -6061,8 +6061,8 @@ static void decode_rr_idirect(DisasContext *ctx)
tcg_gen_andi_tl(cpu_PC, cpu_gpr_a[r1], ~0x1);
break;
case OPC2_32_RR_JLI:
- tcg_gen_movi_tl(cpu_gpr_a[11], ctx->pc_succ_insn);
tcg_gen_andi_tl(cpu_PC, cpu_gpr_a[r1], ~0x1);
+ tcg_gen_movi_tl(cpu_gpr_a[11], ctx->pc_succ_insn);
break;
case OPC2_32_RR_CALLI:
gen_helper_1arg(call, ctx->pc_succ_insn);
--
2.40.1
next prev parent reply other threads:[~2023-06-16 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 15:28 [PATCH v2 0/8] TriCore Privilege Levels Bastian Koppelmann
2023-06-16 15:28 ` Bastian Koppelmann [this message]
2023-06-18 17:30 ` [PATCH v2 1/8] target/tricore: Fix RR_JLI clobbering reg A[11] Richard Henderson
2023-06-16 15:28 ` [PATCH v2 2/8] target/tricore: Introduce DISAS_TARGET_EXIT Bastian Koppelmann
2023-06-18 17:31 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 3/8] target/tricore: ENABLE/DISABLE exit to main-loop Bastian Koppelmann
2023-06-18 17:32 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 4/8] target/tricore: Indirect jump insns use tcg_gen_lookup_and_goto_ptr() Bastian Koppelmann
2023-06-18 17:34 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 5/8] target/tricore: Introduce priv tb flag Bastian Koppelmann
2023-06-16 15:28 ` [PATCH v2 6/8] target/tricore: Implement privilege level for all insns Bastian Koppelmann
2023-06-16 15:28 ` [PATCH v2 7/8] target/tricore: Honour privilege changes on PSW write Bastian Koppelmann
2023-06-18 17:34 ` Richard Henderson
2023-06-16 15:28 ` [PATCH v2 8/8] target/tricore: Fix ICR.IE offset in RESTORE insn Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616152808.1499082-2-kbastian@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).