* [PATCH v2] hw: Fix format for comments
@ 2023-06-19 12:34 Shaoqin Huang
2023-06-19 14:49 ` Peter Xu
0 siblings, 1 reply; 2+ messages in thread
From: Shaoqin Huang @ 2023-06-19 12:34 UTC (permalink / raw)
To: qemu-devel
Cc: Shaoqin Huang, Igor Mammedov, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Whlie
at it, reorder the parameters in comments to match the sequence of
parameters which defined in the CPUArchId.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
---
include/hw/boards.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index a385010909..e0497c2314 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
/**
* CPUArchId:
* @arch_id - architecture-dependent CPU ID of present or possible CPU
+ * @vcpus_count - number of threads provided by @cpu object
+ * @props - CPU object properties, initialized by board
* @cpu - pointer to corresponding CPU object if it's present on NULL otherwise
* @type - QOM class name of possible @cpu object
- * @props - CPU object properties, initialized by board
- * #vcpus_count - number of threads provided by @cpu object
*/
typedef struct CPUArchId {
uint64_t arch_id;
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] hw: Fix format for comments
2023-06-19 12:34 [PATCH v2] hw: Fix format for comments Shaoqin Huang
@ 2023-06-19 14:49 ` Peter Xu
0 siblings, 0 replies; 2+ messages in thread
From: Peter Xu @ 2023-06-19 14:49 UTC (permalink / raw)
To: Shaoqin Huang
Cc: qemu-devel, Igor Mammedov, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang
On Mon, Jun 19, 2023 at 08:34:04AM -0400, Shaoqin Huang wrote:
> Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Whlie
> at it, reorder the parameters in comments to match the sequence of
> parameters which defined in the CPUArchId.
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-19 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19 12:34 [PATCH v2] hw: Fix format for comments Shaoqin Huang
2023-06-19 14:49 ` Peter Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).