From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Juan Quintela" <quintela@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Leonardo Bras" <leobras@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function
Date: Mon, 19 Jun 2023 18:14:34 +0100 [thread overview]
Message-ID: <20230619171437.357374-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230619171437.357374-1-alex.bennee@linaro.org>
Mention that QOM-ified devices already have support for registering
the description.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
include/migration/vmstate.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 084f5e784a..35579b2c1f 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -1209,7 +1209,14 @@ int vmstate_register_with_alias_id(VMStateIf *obj, uint32_t instance_id,
int required_for_version,
Error **errp);
-/* Returns: 0 on success, -1 on failure */
+/**
+ * vmstate_register() - legacy function to register state serialisation description
+ *
+ * New code shouldn't be using this function as QOM-ified devices have
+ * dc->vmsd to store the serialisation description.
+ *
+ * Returns: 0 on success, -1 on failure
+ */
static inline int vmstate_register(VMStateIf *obj, int instance_id,
const VMStateDescription *vmsd,
void *opaque)
--
2.39.2
next prev parent reply other threads:[~2023-06-19 17:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 17:14 [PATCH 0/5] docs/devel: improve API documentation for QOM Alex Bennée
2023-06-19 17:14 ` [PATCH 1/5] docs/devel: add some front matter to the devel index Alex Bennée
2023-06-20 9:57 ` Richard Henderson
2023-06-20 15:37 ` Peter Maydell
2023-06-19 17:14 ` Alex Bennée [this message]
2023-06-20 4:36 ` [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function Philippe Mathieu-Daudé
2023-06-20 9:58 ` Richard Henderson
2023-06-20 14:19 ` Peter Xu
2023-06-21 19:29 ` Juan Quintela
2023-06-19 17:14 ` [PATCH 3/5] include/hw/qdev-core: fixup kerneldoc annotations (!COMPLETE) Alex Bennée
2023-06-20 10:02 ` Richard Henderson
2023-06-19 17:14 ` [PATCH 4/5] docs/devel: split qom-api reference into new file Alex Bennée
2023-06-20 4:38 ` Philippe Mathieu-Daudé
2023-06-20 10:03 ` Richard Henderson
2023-06-20 10:22 ` Philippe Mathieu-Daudé
2023-06-19 17:14 ` [PATCH 5/5] docs/devel: introduce some key concepts for QOM development Alex Bennée
2023-06-20 10:10 ` Richard Henderson
2023-06-20 15:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619171437.357374-3-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=leobras@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).