From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Yanan Wang <wangyanan55@huawei.com>
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Zhenyu Wang" <zhenyu.z.wang@intel.com>,
"Zhao Liu" <zhao1.liu@intel.com>
Subject: [PATCH v3 1/4] machine: Add helpers to get cores/threads per socket
Date: Tue, 20 Jun 2023 18:39:55 +0800 [thread overview]
Message-ID: <20230620103958.3907565-2-zhao1.liu@linux.intel.com> (raw)
In-Reply-To: <20230620103958.3907565-1-zhao1.liu@linux.intel.com>
From: Zhao Liu <zhao1.liu@intel.com>
The number of cores/threads per socket are needed for smbios, and are
also useful for other modules.
Provide the helpers to wrap the calculation of cores/threads per socket
so that we can avoid calculation errors caused by other modules miss
topology changes.
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
v3:
* The new patch to wrap the calculation of cores/threads per socket.
---
include/hw/boards.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index a385010909d5..40ee22fd93e3 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -384,6 +384,18 @@ struct MachineState {
} \
type_init(machine_initfn##_register_types)
+static inline
+unsigned int machine_topo_get_cores_per_socket(const MachineState *ms)
+{
+ return ms->smp.cores * ms->smp.clusters * ms->smp.dies;
+}
+
+static inline
+unsigned int machine_topo_get_threads_per_socket(const MachineState *ms)
+{
+ return ms->smp.threads * machine_topo_get_cores_per_socket(ms);
+}
+
extern GlobalProperty hw_compat_8_0[];
extern const size_t hw_compat_8_0_len;
--
2.34.1
next prev parent reply other threads:[~2023-06-20 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 10:39 [PATCH v3 0/4] hw/smbios: Cleanup topology related variables Zhao Liu
2023-06-20 10:39 ` Zhao Liu [this message]
2023-06-26 13:43 ` [PATCH v3 1/4] machine: Add helpers to get cores/threads per socket Igor Mammedov
2023-06-28 2:20 ` Zhao Liu
2023-06-20 10:39 ` [PATCH v3 2/4] hw/smbios: Fix smbios_smp_sockets caculation Zhao Liu
2023-06-20 10:39 ` [PATCH v3 3/4] hw/smbios: Fix thread count in type4 Zhao Liu
2023-06-26 13:44 ` Igor Mammedov
2023-06-28 2:13 ` Zhao Liu
2023-06-20 10:39 ` [PATCH v3 4/4] hw/smbios: Fix core " Zhao Liu
2023-06-26 13:48 ` [PATCH v3 0/4] hw/smbios: Cleanup topology related variables Igor Mammedov
2023-06-28 3:00 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620103958.3907565-2-zhao1.liu@linux.intel.com \
--to=zhao1.liu@linux.intel.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).