* [PATCH] hw/pci: add comment explaining the reason for checking function 0 in hotplug
@ 2023-06-20 14:25 Ani Sinha
2023-06-20 22:06 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Ani Sinha @ 2023-06-20 14:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Marcel Apfelbaum; +Cc: Ani Sinha, qemu-devel
This change is cosmetic. A comment is added explaining why we need to check for
the availability of function 0 when we hotplug a device.
CC: mst@redhat.com
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
hw/pci/pci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index bf38905b7d..847e534f68 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1179,6 +1179,11 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev,
PCI_SLOT(devfn), PCI_FUNC(devfn), name,
bus->devices[devfn]->name, bus->devices[devfn]->qdev.id);
return NULL;
+ /*
+ * Populating function 0 triggers a scan from the guest that
+ * exposes other non-zero functions. Hence we need to ensure that
+ * function 0 wasn't added yet.
+ */
} else if (dev->hotplugged &&
!pci_is_vf(pci_dev) &&
pci_get_function_0(pci_dev)) {
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/pci: add comment explaining the reason for checking function 0 in hotplug
2023-06-20 14:25 [PATCH] hw/pci: add comment explaining the reason for checking function 0 in hotplug Ani Sinha
@ 2023-06-20 22:06 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2023-06-20 22:06 UTC (permalink / raw)
To: Ani Sinha; +Cc: Marcel Apfelbaum, qemu-devel
On Tue, Jun 20, 2023 at 07:55:51PM +0530, Ani Sinha wrote:
> This change is cosmetic. A comment is added explaining why we need to check for
> the availability of function 0 when we hotplug a device.
>
> CC: mst@redhat.com
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> hw/pci/pci.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index bf38905b7d..847e534f68 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1179,6 +1179,11 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev,
> PCI_SLOT(devfn), PCI_FUNC(devfn), name,
> bus->devices[devfn]->name, bus->devices[devfn]->qdev.id);
> return NULL;
> + /*
> + * Populating function 0 triggers a scan from the guest that
> + * exposes other non-zero functions. Hence we need to ensure that
> + * function 0 wasn't added yet.
> + */
bad place for the comment
> }
stick the comment here
> else
or here
> if (dev->hotplugged &&
> !pci_is_vf(pci_dev) &&
> pci_get_function_0(pci_dev)) {
> --
> 2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-20 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 14:25 [PATCH] hw/pci: add comment explaining the reason for checking function 0 in hotplug Ani Sinha
2023-06-20 22:06 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).