From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8091EB64D7 for ; Tue, 20 Jun 2023 14:41:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBcXj-0004Yr-83; Tue, 20 Jun 2023 10:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBcXh-0004Xv-1W for qemu-devel@nongnu.org; Tue, 20 Jun 2023 10:41:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBcXf-000792-K7 for qemu-devel@nongnu.org; Tue, 20 Jun 2023 10:41:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687272049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NS6iJj9ZYraYMqYtcqEbHnR62qF6mLsZRWuy0Yfoj5g=; b=KwnZHMM4NiOwmxBn+oGSd3xcacAvKreFTRHzUHmJ/DLeO5x8z953gpt9oqWinzNUD5H8B4 0kQl/dJm4TaVlxP4Pc940t0ew91b1WHYQEuCZffvS9m7wVuga3vmAv+X6D4lklYtR6p8x9 s05fIiZ0osrJr3jZw/fOWPtkOEGjVpk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-eF1IDbo6Nkqsd4mlfzO_ag-1; Tue, 20 Jun 2023 10:40:44 -0400 X-MC-Unique: eF1IDbo6Nkqsd4mlfzO_ag-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 797978CB787; Tue, 20 Jun 2023 14:35:39 +0000 (UTC) Received: from localhost (unknown [10.39.194.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB5DC40C2063; Tue, 20 Jun 2023 14:35:38 +0000 (UTC) Date: Tue, 20 Jun 2023 16:35:37 +0200 From: Stefan Hajnoczi To: Alexander Graf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, Cameron Esfahani , Roman Bolshakov , "Michael S. Tsirkin" , Kevin Wolf , Hanna Reitz , Marcel Apfelbaum , Paolo Bonzini , Peter Maydell Subject: Re: [PATCH 05/12] hw/virtio: Add support for apple virtio-blk Message-ID: <20230620143537.GD2625194@fedora> References: <20230614224038.86148-1-graf> <20230614225626.97734-1-graf@amazon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f+gUStivgWLpd+Tn" Content-Disposition: inline In-Reply-To: <20230614225626.97734-1-graf@amazon.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --f+gUStivgWLpd+Tn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 14, 2023 at 10:56:22PM +0000, Alexander Graf wrote: > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 39e7f23fab..76b85bb3cb 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -1120,6 +1120,20 @@ static int virtio_blk_handle_request(VirtIOBlockRe= q *req, MultiReqBuffer *mrb) > =20 > break; > } > + case VIRTIO_BLK_T_APPLE1: > + { > + if (s->conf.x_apple_type) { > + /* Only valid on Apple Virtio */ > + char buf[iov_size(in_iov, in_num)]; I'm concerned that a variable-sized stack buffer could be abused by a malicious guest. Even if it's harmless in the Apple use case, someone else might copy this approach and use it where it creates a security problem. Please either implement iov_memset() or allocate the temporary buffer using bdrv_blockalign() (and free it with qemu_vfree()). > + memset(buf, 0, sizeof(buf)); > + iov_from_buf(in_iov, in_num, 0, buf, sizeof(buf)); > + virtio_blk_req_complete(req, VIRTIO_BLK_S_OK); --f+gUStivgWLpd+Tn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmSRuTkACgkQnKSrs4Gr c8gXyQf/a/dAGy7yH5m+O8jsAgPajzhILNEhPzumEK/q/YdHE58pEBhJPl6KDcfc X1fllPg9yiqfocCqGIIgqHBrj965W9P3O7MCMy/aFeIobK5BUYbhmtaB3OyYzbvd fmMVoRZ4igjlQ50gyvoMYK6sKJ7/K9rjZlVyj9jQtNfJv++srwXwtbriNUgVKRgz Qkil3OaaA3iuMqYE45z2LVifVd2VrsSj7K9E3W85gL+tRe0veBC9amhx/z//Dt4l i8DmqNBd5lMNo4sqnqmtFzdYy+7Xv1B5C0GVr0Tw0lrdZchGsbZXdydJMa6n8sqQ i7XiN/+L8o36OM08f8Eujc430udbpg== =yRQO -----END PGP SIGNATURE----- --f+gUStivgWLpd+Tn--