From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "Beraldo Leal" <bleal@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"John Snow" <jsnow@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH RFC 0/6] Switch iotests to pyvenv
Date: Tue, 20 Jun 2023 20:21:15 -0400 [thread overview]
Message-ID: <20230621002121.1609612-1-jsnow@redhat.com> (raw)
Hi, this is ... a fairly incomplete series about trying to get iotests
to run out of the configure-time venv. I'm looking for some feedback, so
out to the list it goes.
Primarily, I'm having doubts about these points:
1) I think I need something like "mkvenv install" in the first patch,
but mkvenv.py is getting pretty long...
2) Is there a way to optimize the speed for patch #2? Maybe installing
this package can be skipped until it's needed, but that means that
things like iotest's ./check might get complicated to support that.
3) I cheated quite a bit in patch 4 to use the correct Python to launch
iotests, but I'm wondering if there's a nicer way to solve this
more *completely*.
John Snow (6):
experiment: add mkvenv install
build, tests: Add qemu in-tree packages to pyvenv at configure time.
iotests: get rid of '..' in path environment output
iotests: use the correct python to run linters
iotests: use pyvenv/bin/python3 to launch child test processes
iotests: don't add qemu.git/python to PYTHONPATH
configure | 31 +++++++++++++++++++++++++++
python/scripts/mkvenv.py | 40 +++++++++++++++++++++++++++++++++++
tests/qemu-iotests/linters.py | 2 +-
tests/qemu-iotests/testenv.py | 21 ++++++++++++------
4 files changed, 87 insertions(+), 7 deletions(-)
--
2.40.1
next reply other threads:[~2023-06-21 0:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 0:21 John Snow [this message]
2023-06-21 0:21 ` [PATCH RFC 1/6] experiment: add mkvenv install John Snow
2023-06-21 0:21 ` [PATCH RFC 2/6] build, tests: Add qemu in-tree packages to pyvenv at configure time John Snow
2023-06-21 0:21 ` [PATCH RFC 3/6] iotests: get rid of '..' in path environment output John Snow
2023-06-21 0:21 ` [PATCH RFC 4/6] iotests: use the correct python to run linters John Snow
2023-06-21 0:21 ` [PATCH RFC 5/6] iotests: use pyvenv/bin/python3 to launch child test processes John Snow
2023-06-21 0:21 ` [PATCH RFC 6/6] iotests: don't add qemu.git/python to PYTHONPATH John Snow
2023-06-21 7:08 ` [PATCH RFC 0/6] Switch iotests to pyvenv Paolo Bonzini
2023-06-22 9:24 ` Paolo Bonzini
2023-06-22 21:03 ` John Snow
2023-06-22 21:04 ` Paolo Bonzini
2023-06-22 21:07 ` John Snow
2023-06-22 21:11 ` Paolo Bonzini
2023-06-22 21:18 ` John Snow
2023-06-22 21:57 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621002121.1609612-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).