From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADF34EB64D8 for ; Wed, 21 Jun 2023 14:58:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBzHw-0007TM-NE; Wed, 21 Jun 2023 10:58:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBzHt-0007Sz-UC for qemu-devel@nongnu.org; Wed, 21 Jun 2023 10:58:25 -0400 Received: from 7.mo552.mail-out.ovh.net ([188.165.59.253]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBzHp-0007uS-Dt for qemu-devel@nongnu.org; Wed, 21 Jun 2023 10:58:25 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.156.35]) by mo552.mail-out.ovh.net (Postfix) with ESMTPS id D53FE2B07B; Wed, 21 Jun 2023 14:58:03 +0000 (UTC) Received: from kaod.org (37.59.142.106) by DAG6EX1.mxp5.local (172.16.2.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 21 Jun 2023 16:58:03 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-106R006dd416d25-b1da-47d6-8088-695861588f76, 909E68869DE5F343E5F9AFAFEE281BFD2240853A) smtp.auth=groug@kaod.org X-OVh-ClientIp: 78.197.208.248 Date: Wed, 21 Jun 2023 16:58:02 +0200 From: Greg Kurz To: Christian Schoenebeck CC: Subject: Re: [PATCH v3] 9pfs: deprecate 'proxy' backend Message-ID: <20230621165802.724bae7b@bahia> In-Reply-To: <1802263.gKGKeHe8zJ@silver> References: <10417219.URJpt1F07l@silver> <20230621154136.6e1f3f4b@bahia> <1802263.gKGKeHe8zJ@silver> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.106] X-ClientProxiedBy: DAG6EX2.mxp5.local (172.16.2.52) To DAG6EX1.mxp5.local (172.16.2.51) X-Ovh-Tracer-GUID: 0a578265-68f0-4ad0-bde1-414cc8b4af55 X-Ovh-Tracer-Id: 1151514133701564826 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefkedgheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpeffhffvvefukfgjfhfogggtgfhisehtjeertdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpefhhefhudegleffffegvdejleeludethffhteeiuedtfeetleekheettdevteeugeenucffohhmrghinhepphgrthgthhgvfidrohhrghenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtiedpjeekrdduleejrddvtdekrddvgeeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeoghhrohhugheskhgrohgurdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehqvghmuhgpohhsshestghruhguvggshihtvgdrtghomhdpqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghdpoffvtefjohhsthepmhhoheehvddpmhhouggvpehsmhhtphhouhht Received-SPF: pass client-ip=188.165.59.253; envelope-from=groug@kaod.org; helo=7.mo552.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 21 Jun 2023 16:16:46 +0200 Christian Schoenebeck wrote: > On Wednesday, June 21, 2023 3:41:36 PM CEST Greg Kurz wrote: > > On Wed, 21 Jun 2023 15:32:39 +0200 > > Christian Schoenebeck wrote: > > > > > On Thursday, June 15, 2023 11:35:05 AM CEST Christian Schoenebeck wrote: > > > > On Saturday, June 10, 2023 3:39:44 PM CEST Christian Schoenebeck wrote: > > > > > As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is > in > > > > > bad shape. Using the 'proxy' backend was already discouraged for > safety > > > > > reasons before and we recommended to use the 'local' backend instead, > > > > > but now it is time to officially deprecate the 'proxy' backend. > > > > > > > > > > Signed-off-by: Christian Schoenebeck > > > > > > Ping > > > > > > > It seems you missed the review I posted last week : > > > > https://patchew.org/QEMU/E1q7ytt-0005Fl-JX@lizzy.crudebyte.com/ > #20230612165742.3333ea08@bahia > > Oh, I never received your email. I'll check the logs what happened there. > > I'll send a v4 with your suggestions, they make sense. > > Do you want me to add your "for the records" comments as well in the > deprecation notice? > This was more targeting qemu-devel archives or git log, but feel free to provide relevant details in the deprecation notice. I agree with Daniel that virtiofsd should also be mentioned as an alternative. > Best regards, > Christian Schoenebeck > > Cheers, -- Greg