qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <laurent@vivier.eu>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Jason Wang" <jasowang@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 14/24] hw/net/dp8393x.c: move TYPE_DP8393X and dp8393xState into dp8393x.h
Date: Thu, 22 Jun 2023 09:55:34 +0200	[thread overview]
Message-ID: <20230622075544.210899-15-laurent@vivier.eu> (raw)
In-Reply-To: <20230622075544.210899-1-laurent@vivier.eu>

From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

This is to enable them to be used outside of dp8393x.c.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
CC: Jason Wang <jasowang@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230621085353.113233-15-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 include/hw/net/dp8393x.h | 60 ++++++++++++++++++++++++++++++++++++++++
 hw/net/dp8393x.c         | 32 +--------------------
 2 files changed, 61 insertions(+), 31 deletions(-)
 create mode 100644 include/hw/net/dp8393x.h

diff --git a/include/hw/net/dp8393x.h b/include/hw/net/dp8393x.h
new file mode 100644
index 000000000000..4a3f7478be44
--- /dev/null
+++ b/include/hw/net/dp8393x.h
@@ -0,0 +1,60 @@
+/*
+ * QEMU NS SONIC DP8393x netcard
+ *
+ * Copyright (c) 2008-2009 Herve Poussineau
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef HW_NET_DP8393X_H
+#define HW_NET_DP8393X_H
+
+#include "hw/sysbus.h"
+#include "net/net.h"
+#include "exec/memory.h"
+
+#define SONIC_REG_COUNT  0x40
+
+#define TYPE_DP8393X "dp8393x"
+OBJECT_DECLARE_SIMPLE_TYPE(dp8393xState, DP8393X)
+
+struct dp8393xState {
+    SysBusDevice parent_obj;
+
+    /* Hardware */
+    uint8_t it_shift;
+    bool big_endian;
+    bool last_rba_is_full;
+    qemu_irq irq;
+    int irq_level;
+    QEMUTimer *watchdog;
+    int64_t wt_last_update;
+    NICConf conf;
+    NICState *nic;
+    MemoryRegion mmio;
+
+    /* Registers */
+    uint16_t cam[16][3];
+    uint16_t regs[SONIC_REG_COUNT];
+
+    /* Temporaries */
+    uint8_t tx_buffer[0x10000];
+    int loopback_packet;
+
+    /* Memory access */
+    MemoryRegion *dma_mr;
+    AddressSpace as;
+};
+
+#endif
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 45b954e46c25..a596f7fbc6b0 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -20,6 +20,7 @@
 #include "qemu/osdep.h"
 #include "hw/irq.h"
 #include "hw/qdev-properties.h"
+#include "hw/net/dp8393x.h"
 #include "hw/sysbus.h"
 #include "migration/vmstate.h"
 #include "net/net.h"
@@ -85,7 +86,6 @@ static const char *reg_names[] = {
 #define SONIC_MPT    0x2e
 #define SONIC_MDT    0x2f
 #define SONIC_DCR2   0x3f
-#define SONIC_REG_COUNT  0x40
 
 #define SONIC_CR_HTX     0x0001
 #define SONIC_CR_TXP     0x0002
@@ -139,36 +139,6 @@ static const char *reg_names[] = {
 #define SONIC_DESC_EOL   0x0001
 #define SONIC_DESC_ADDR  0xFFFE
 
-#define TYPE_DP8393X "dp8393x"
-OBJECT_DECLARE_SIMPLE_TYPE(dp8393xState, DP8393X)
-
-struct dp8393xState {
-    SysBusDevice parent_obj;
-
-    /* Hardware */
-    uint8_t it_shift;
-    bool big_endian;
-    bool last_rba_is_full;
-    qemu_irq irq;
-    int irq_level;
-    QEMUTimer *watchdog;
-    int64_t wt_last_update;
-    NICConf conf;
-    NICState *nic;
-    MemoryRegion mmio;
-
-    /* Registers */
-    uint16_t cam[16][3];
-    uint16_t regs[SONIC_REG_COUNT];
-
-    /* Temporaries */
-    uint8_t tx_buffer[0x10000];
-    int loopback_packet;
-
-    /* Memory access */
-    MemoryRegion *dma_mr;
-    AddressSpace as;
-};
 
 /*
  * Accessor functions for values which are formed by
-- 
2.40.1



  parent reply	other threads:[~2023-06-22  7:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  7:55 [PULL 00/24] Q800 for 8.1 patches Laurent Vivier
2023-06-22  7:55 ` [PULL 01/24] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array Laurent Vivier
2023-06-22  7:55 ` [PULL 02/24] q800: add missing space after parent object in GLUEState Laurent Vivier
2023-06-22  7:55 ` [PULL 03/24] q800: introduce Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 04/24] q800: rename q800_init() to q800_machine_init() Laurent Vivier
2023-06-22  7:55 ` [PULL 05/24] q800: move CPU object into Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 06/24] q800: move ROM memory region to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 07/24] q800: move GLUE device into separate q800-glue.c file Laurent Vivier
2023-06-22  7:55 ` [PULL 08/24] q800-glue.c: switch TypeInfo registration to use DEFINE_TYPES() macro Laurent Vivier
2023-06-22  7:55 ` [PULL 09/24] q800: move GLUE device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 10/24] q800: introduce mac-io container memory region Laurent Vivier
2023-06-22  7:55 ` [PULL 11/24] q800: reimplement mac-io region aliasing using IO " Laurent Vivier
2023-06-22  7:55 ` [PULL 12/24] q800: move VIA1 device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 13/24] q800: move VIA2 " Laurent Vivier
2023-06-22  7:55 ` Laurent Vivier [this message]
2023-06-22  7:55 ` [PULL 15/24] q800: move dp8393x " Laurent Vivier
2023-06-22  7:55 ` [PULL 16/24] q800: move ESCC " Laurent Vivier
2023-06-22  7:55 ` [PULL 17/24] q800: move escc_orgate " Laurent Vivier
2023-06-22  7:55 ` [PULL 18/24] q800: move ESP " Laurent Vivier
2023-06-22  7:55 ` [PULL 19/24] q800: move SWIM " Laurent Vivier
2023-06-22  7:55 ` [PULL 20/24] q800: move mac-nubus-bridge " Laurent Vivier
2023-06-22  7:55 ` [PULL 21/24] q800: don't access Nubus bus directly from the mac-nubus-bridge device Laurent Vivier
2023-06-22  7:55 ` [PULL 22/24] q800: move macfb device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 23/24] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf Laurent Vivier
2023-06-22  7:55 ` [PULL 24/24] mac_via: fix rtc command decoding for the PRAM seconds registers Laurent Vivier
2023-06-22 13:17 ` [PULL 00/24] Q800 for 8.1 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622075544.210899-15-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=jasowang@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).