qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <laurent@vivier.eu>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Jason Wang" <jasowang@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 15/24] q800: move dp8393x device to Q800MachineState
Date: Thu, 22 Jun 2023 09:55:35 +0200	[thread overview]
Message-ID: <20230622075544.210899-16-laurent@vivier.eu> (raw)
In-Reply-To: <20230622075544.210899-1-laurent@vivier.eu>

From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Also change the instantiation of the dp8393x device to use object_initialize_child().

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
CC: Jason Wang <jasowang@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20230621085353.113233-16-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 include/hw/m68k/q800.h | 2 ++
 hw/m68k/q800.c         | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/hw/m68k/q800.h b/include/hw/m68k/q800.h
index 06c771635b3f..d11bc020ed98 100644
--- a/include/hw/m68k/q800.h
+++ b/include/hw/m68k/q800.h
@@ -29,6 +29,7 @@
 #include "exec/memory.h"
 #include "hw/m68k/q800-glue.h"
 #include "hw/misc/mac_via.h"
+#include "hw/net/dp8393x.h"
 
 /*
  * The main Q800 machine
@@ -42,6 +43,7 @@ struct Q800MachineState {
     GLUEState glue;
     MOS6522Q800VIA1State via1;
     MOS6522Q800VIA2State via2;
+    dp8393xState dp8393x;
     MemoryRegion macio;
     MemoryRegion macio_alias;
 };
diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index 988b4981b830..13806613fa36 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -315,14 +315,16 @@ static void q800_machine_init(MachineState *machine)
     nd_table[0].macaddr.a[1] = 0x00;
     nd_table[0].macaddr.a[2] = 0x07;
 
-    dev = qdev_new("dp8393x");
+    object_initialize_child(OBJECT(machine), "dp8393x", &m->dp8393x,
+                            TYPE_DP8393X);
+    dev = DEVICE(&m->dp8393x);
     qdev_set_nic_properties(dev, &nd_table[0]);
     qdev_prop_set_uint8(dev, "it_shift", 2);
     qdev_prop_set_bit(dev, "big_endian", true);
     object_property_set_link(OBJECT(dev), "dma_mr",
                              OBJECT(get_system_memory()), &error_abort);
     sysbus = SYS_BUS_DEVICE(dev);
-    sysbus_realize_and_unref(sysbus, &error_fatal);
+    sysbus_realize(sysbus, &error_fatal);
     memory_region_add_subregion(&m->macio, SONIC_BASE - IO_BASE,
                                 sysbus_mmio_get_region(sysbus, 0));
     sysbus_connect_irq(sysbus, 0,
-- 
2.40.1



  parent reply	other threads:[~2023-06-22  7:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  7:55 [PULL 00/24] Q800 for 8.1 patches Laurent Vivier
2023-06-22  7:55 ` [PULL 01/24] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array Laurent Vivier
2023-06-22  7:55 ` [PULL 02/24] q800: add missing space after parent object in GLUEState Laurent Vivier
2023-06-22  7:55 ` [PULL 03/24] q800: introduce Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 04/24] q800: rename q800_init() to q800_machine_init() Laurent Vivier
2023-06-22  7:55 ` [PULL 05/24] q800: move CPU object into Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 06/24] q800: move ROM memory region to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 07/24] q800: move GLUE device into separate q800-glue.c file Laurent Vivier
2023-06-22  7:55 ` [PULL 08/24] q800-glue.c: switch TypeInfo registration to use DEFINE_TYPES() macro Laurent Vivier
2023-06-22  7:55 ` [PULL 09/24] q800: move GLUE device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 10/24] q800: introduce mac-io container memory region Laurent Vivier
2023-06-22  7:55 ` [PULL 11/24] q800: reimplement mac-io region aliasing using IO " Laurent Vivier
2023-06-22  7:55 ` [PULL 12/24] q800: move VIA1 device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 13/24] q800: move VIA2 " Laurent Vivier
2023-06-22  7:55 ` [PULL 14/24] hw/net/dp8393x.c: move TYPE_DP8393X and dp8393xState into dp8393x.h Laurent Vivier
2023-06-22  7:55 ` Laurent Vivier [this message]
2023-06-22  7:55 ` [PULL 16/24] q800: move ESCC device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 17/24] q800: move escc_orgate " Laurent Vivier
2023-06-22  7:55 ` [PULL 18/24] q800: move ESP " Laurent Vivier
2023-06-22  7:55 ` [PULL 19/24] q800: move SWIM " Laurent Vivier
2023-06-22  7:55 ` [PULL 20/24] q800: move mac-nubus-bridge " Laurent Vivier
2023-06-22  7:55 ` [PULL 21/24] q800: don't access Nubus bus directly from the mac-nubus-bridge device Laurent Vivier
2023-06-22  7:55 ` [PULL 22/24] q800: move macfb device to Q800MachineState Laurent Vivier
2023-06-22  7:55 ` [PULL 23/24] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf Laurent Vivier
2023-06-22  7:55 ` [PULL 24/24] mac_via: fix rtc command decoding for the PRAM seconds registers Laurent Vivier
2023-06-22 13:17 ` [PULL 00/24] Q800 for 8.1 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622075544.210899-16-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=jasowang@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).