From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH v3 15/19] target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext()
Date: Fri, 23 Jun 2023 11:46:31 +0200 [thread overview]
Message-ID: <20230623-cceea5c383211d53109bc04b@orel> (raw)
In-Reply-To: <20230622135700.105383-16-dbarboza@ventanamicro.com>
On Thu, Jun 22, 2023 at 10:56:56AM -0300, Daniel Henrique Barboza wrote:
> riscv_isa_string_ext() is being used by riscv_isa_string(), which is
> then used by boards to retrieve the 'riscv,isa' string to be written in
> the FDT. All this happens after riscv_cpu_realize(), meaning that we're
> already past riscv_cpu_validate_set_extensions() and, more important,
> riscv_cpu_disable_priv_spec_isa_exts().
>
> This means that all extensions that needed to be disabled due to
> priv_spec mismatch are already disabled. Checking this again during
> riscv_isa_string_ext() is unneeded. Remove it.
>
> As a bonus, riscv_isa_string_ext() can now be used with the 'host'
> KVM-only CPU type since it doesn't have a env->priv_ver assigned and it
> would fail this check for no good reason.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> ---
> target/riscv/cpu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 5a50cb1d0b..b65db165cc 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -2001,8 +2001,7 @@ static void riscv_isa_string_ext(RISCVCPU *cpu, char **isa_str,
> int i;
>
> for (i = 0; i < ARRAY_SIZE(isa_edata_arr); i++) {
> - if (cpu->env.priv_ver >= isa_edata_arr[i].min_version &&
> - isa_ext_is_enabled(cpu, &isa_edata_arr[i])) {
> + if (isa_ext_is_enabled(cpu, &isa_edata_arr[i])) {
> new = g_strconcat(old, "_", isa_edata_arr[i].name, NULL);
> g_free(old);
> old = new;
> --
> 2.41.0
>
Nice!
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
next prev parent reply other threads:[~2023-06-23 9:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:56 [PATCH v3 00/19] target/riscv, KVM: fixes and enhancements Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 01/19] target/riscv: skip features setup for KVM CPUs Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 02/19] hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 03/19] target/riscv/cpu.c: restrict 'mvendorid' value Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 04/19] target/riscv/cpu.c: restrict 'mimpid' value Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 05/19] target/riscv/cpu.c: restrict 'marchid' value Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 06/19] target/riscv: use KVM scratch CPUs to init KVM properties Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 07/19] target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids() Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 08/19] target/riscv: handle mvendorid/marchid/mimpid for KVM CPUs Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 09/19] linux-headers: Update to v6.4-rc1 Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 10/19] target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 11/19] target/riscv/cpu: add misa_ext_info_arr[] Daniel Henrique Barboza
2023-06-23 9:30 ` Andrew Jones
2023-06-22 13:56 ` [PATCH v3 12/19] target/riscv: add KVM specific MISA properties Daniel Henrique Barboza
2023-06-23 9:38 ` Andrew Jones
2023-06-23 14:14 ` Daniel Henrique Barboza
2023-06-24 7:32 ` Andrew Jones
2023-06-25 22:38 ` Daniel Henrique Barboza
2023-06-26 6:24 ` Andrew Jones
2023-06-22 13:56 ` [PATCH v3 13/19] target/riscv/kvm.c: update KVM MISA bits Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 14/19] target/riscv/kvm.c: add multi-letter extension KVM properties Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 15/19] target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext() Daniel Henrique Barboza
2023-06-23 9:46 ` Andrew Jones [this message]
2023-06-22 13:56 ` [PATCH v3 16/19] target/riscv/cpu.c: create KVM mock properties Daniel Henrique Barboza
2023-06-23 9:58 ` Andrew Jones
2023-06-23 14:28 ` Daniel Henrique Barboza
2023-06-24 7:41 ` Andrew Jones
2023-06-26 17:27 ` Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 17/19] target/riscv: update multi-letter extension KVM properties Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 18/19] target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper Daniel Henrique Barboza
2023-06-22 13:57 ` [PATCH v3 19/19] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623-cceea5c383211d53109bc04b@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).