qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Peter Xu" <peterx@redhat.com>,
	qemu-arm@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Bandan Das" <bsd@redhat.com>,
	"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	"Radoslaw Biernacki" <rad@semihalf.com>,
	"Alexander Bulekov" <alxndr@bu.edu>,
	"Leif Lindholm" <quic_llindhol@quicinc.com>,
	"Qiuhao Li" <Qiuhao.Li@outlook.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Bin Meng" <bmeng.cn@gmail.com>, "Thomas Huth" <thuth@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Ani Sinha" <anisinha@redhat.com>
Subject: [PATCH 04/26] docs/devel: remind developers to run CI container pipeline when updating images
Date: Fri, 23 Jun 2023 13:20:38 +0100	[thread overview]
Message-ID: <20230623122100.1640995-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230623122100.1640995-1-alex.bennee@linaro.org>

From: Ani Sinha <anisinha@redhat.com>

When new dependencies and packages are added to containers, its important to
run CI container generation pipelines on gitlab to make sure that there are no
obvious conflicts between packages that are being added and those that are
already present. Running CI container pipelines will make sure that there are
no such breakages before we commit the change updating the containers. Add a
line in the documentation reminding developers to run the pipeline before
submitting the change. It will also ease the life of the maintainers.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230506072012.10350-1-anisinha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 docs/devel/testing.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 203facb417..8f18052ba7 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project:
    `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
    page on how to trigger gitlab CI pipelines on your change.
 
+ * Please also trigger gitlab container generation pipelines on your change
+   for as many OS distros as practical to make sure that there are no
+   obvious breakages when adding the new pre-requisite. Please see
+   `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
+   page on how to trigger gitlab CI pipelines on your change.
+
 For enterprise distros that default to old, end-of-life versions of the
 Python runtime, QEMU uses a separate set of mappings that work with more
 recent versions.  These can be found in ``tests/lcitool/mappings.yml``.
-- 
2.39.2



  parent reply	other threads:[~2023-06-23 12:22 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 12:20 [PATCH 00/26] maintainer omnibus: testing, fuzz, plugins, documentation Alex Bennée
2023-06-23 12:20 ` [PATCH 01/26] gitlab: explicit set artifacts publishing criteria Alex Bennée
2023-06-26  7:58   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 02/26] gitlab: ensure coverage job also publishes meson log Alex Bennée
2023-06-26  7:59   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 03/26] gitlab: reduce testing scope of check-gcov Alex Bennée
2023-06-26  7:59   ` Richard Henderson
2023-06-23 12:20 ` Alex Bennée [this message]
2023-06-23 12:20 ` [PATCH 05/26] tests/tcg: add mechanism to handle plugin arguments Alex Bennée
2023-06-23 12:20 ` [PATCH 06/26] qemu-keymap: use modern name for Arabic keymap Alex Bennée
2023-06-23 12:23   ` Peter Maydell
2023-06-23 12:20 ` [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index Alex Bennée
2023-06-23 12:25   ` Peter Maydell
2023-06-26 20:21     ` Alex Bennée
2023-06-23 12:20 ` [PATCH 08/26] scripts/oss-fuzz: add a suppression for keymap Alex Bennée
2023-06-26  8:02   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 09/26] tests/qtests: clean-up and fix leak in generic_fuzz Alex Bennée
2023-06-26  8:06   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 10/26] tests/docker: add test-fuzz Alex Bennée
2023-06-23 12:20 ` [PATCH 11/26] Makefile: add lcitool-refresh to UNCHECKED_GOALS Alex Bennée
2023-06-23 15:10   ` Philippe Mathieu-Daudé
2023-06-23 12:20 ` [PATCH 12/26] tests/lcitool: update to latest version Alex Bennée
2023-06-26  8:08   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 13/26] tests/lcitool: Bump fedora container versions Alex Bennée
2023-06-26  8:09   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 14/26] tests/lcitool: add an explicit gcc-native package Alex Bennée
2023-06-26  8:10   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 15/26] tests/lcitool: introduce qemu-minimal Alex Bennée
2023-06-26  8:14   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 16/26] tests/docker: convert riscv64-cross to lcitool Alex Bennée
2023-06-26  8:16   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 17/26] tests/avocado: update firmware to enable sbsa-ref/max Alex Bennée
2023-06-23 15:14   ` Philippe Mathieu-Daudé
2023-06-23 12:20 ` [PATCH 18/26] plugins: force slow path when plugins instrument memory ops Alex Bennée
2023-06-23 12:20 ` [PATCH 19/26] plugins: fix memory leak while parsing options Alex Bennée
2023-06-26  8:24   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 20/26] plugins: update lockstep to use g_memdup2 Alex Bennée
2023-06-26  8:25   ` Richard Henderson
2023-06-23 12:20 ` [PATCH 21/26] docs/devel: add some front matter to the devel index Alex Bennée
2023-06-23 12:20 ` [PATCH 22/26] include/migration: mark vmstate_register() as a legacy function Alex Bennée
2023-06-23 12:20 ` [PATCH 23/26] include/hw/qdev-core: fixup kerneldoc annotations Alex Bennée
2023-06-23 12:20 ` [PATCH 24/26] docs/devel/qom.rst: Correct code style Alex Bennée
2023-06-23 12:20 ` [PATCH 25/26] docs/devel: split qom-api reference into new file Alex Bennée
2023-06-23 12:21 ` [PATCH 26/26] docs/devel: introduce some key concepts for QOM development Alex Bennée
2023-06-26 13:27   ` Paolo Bonzini
2023-06-26 13:39     ` Alex Bennée
2023-06-26 15:43       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230623122100.1640995-5-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Qiuhao.Li@outlook.com \
    --cc=alxndr@bu.edu \
    --cc=anisinha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=bsd@redhat.com \
    --cc=crosa@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=leobras@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    --cc=quintela@redhat.com \
    --cc=rad@semihalf.com \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).