qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing
@ 2023-06-22 11:41 Thomas Huth
  2023-06-23 13:20 ` Jonathan Cameron via
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2023-06-22 11:41 UTC (permalink / raw)
  To: qemu-devel, Jonathan Cameron; +Cc: qemu-trivial, Fan Ni

It's good style to clean up temporary directories when they
are not needed anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/cxl-test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c
index edcad4a0ce..a600331843 100644
--- a/tests/qtest/cxl-test.c
+++ b/tests/qtest/cxl-test.c
@@ -124,6 +124,7 @@ static void cxl_t3d_deprecated(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_t3d_persistent(void)
@@ -138,6 +139,7 @@ static void cxl_t3d_persistent(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_t3d_volatile(void)
-- 
2.39.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing
  2023-06-22 11:41 [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing Thomas Huth
@ 2023-06-23 13:20 ` Jonathan Cameron via
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron via @ 2023-06-23 13:20 UTC (permalink / raw)
  To: Thomas Huth; +Cc: qemu-devel, qemu-trivial, Fan Ni

On Thu, 22 Jun 2023 13:41:32 +0200
Thomas Huth <thuth@redhat.com> wrote:

> It's good style to clean up temporary directories when they
> are not needed anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  tests/qtest/cxl-test.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c
> index edcad4a0ce..a600331843 100644
> --- a/tests/qtest/cxl-test.c
> +++ b/tests/qtest/cxl-test.c
> @@ -124,6 +124,7 @@ static void cxl_t3d_deprecated(void)
>  
>      qtest_start(cmdline->str);
>      qtest_end();
> +    rmdir(tmpfs);
>  }
>  
>  static void cxl_t3d_persistent(void)
> @@ -138,6 +139,7 @@ static void cxl_t3d_persistent(void)
>  
>      qtest_start(cmdline->str);
>      qtest_end();
> +    rmdir(tmpfs);
>  }
>  
>  static void cxl_t3d_volatile(void)



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-23 13:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-22 11:41 [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing Thomas Huth
2023-06-23 13:20 ` Jonathan Cameron via

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).