From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH v3 12/19] target/riscv: add KVM specific MISA properties
Date: Sat, 24 Jun 2023 09:32:47 +0200 [thread overview]
Message-ID: <20230624-bd82bafb08e5daa8fb81b72f@orel> (raw)
In-Reply-To: <6da71298-8345-f0b1-b086-830425db6ec5@ventanamicro.com>
On Fri, Jun 23, 2023 at 11:14:45AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 6/23/23 06:38, Andrew Jones wrote:
> > On Thu, Jun 22, 2023 at 10:56:53AM -0300, Daniel Henrique Barboza wrote:
> > ...
> > > +#define KVM_MISA_CFG(_bit, _reg_id) \
> > > + {.offset = _bit, .kvm_reg_id = _reg_id}
> > > +
> > > +/* KVM ISA extensions */
> > > +static KVMCPUConfig kvm_misa_ext_cfgs[] = {
> > > + KVM_MISA_CFG(RVA, KVM_RISCV_ISA_EXT_A),
> > > + KVM_MISA_CFG(RVC, KVM_RISCV_ISA_EXT_C),
> > > + KVM_MISA_CFG(RVD, KVM_RISCV_ISA_EXT_D),
> > > + KVM_MISA_CFG(RVF, KVM_RISCV_ISA_EXT_F),
> > > + KVM_MISA_CFG(RVH, KVM_RISCV_ISA_EXT_H),
> > > + KVM_MISA_CFG(RVI, KVM_RISCV_ISA_EXT_I),
> > > + KVM_MISA_CFG(RVM, KVM_RISCV_ISA_EXT_M),
> > > +};
> > > +
> > ...
> > > +static void kvm_riscv_add_cpu_user_properties(Object *cpu_obj)
> > > +{
> > > + int i;
> > > +
> > > + for (i = 0; i < ARRAY_SIZE(kvm_misa_ext_cfgs); i++) {
> > > + KVMCPUConfig *misa_cfg = &kvm_misa_ext_cfgs[i];
> > > + int bit = misa_cfg->offset;
> > > +
> > > + misa_cfg->name = misa_ext_info_arr[bit].name;
> > > + misa_cfg->description = misa_ext_info_arr[bit].description;
> >
> > I'd prefer these be set by KVM_MISA_CFG(), since we can. No need to wait
> > until runtime if we can do it at compile-time.
>
> The compiler will complain about "error: initializer element is not constant" and
> the build will fail. This happens because, apparently, the compiler doesn't see the
> imported array as a constant, regardless of the 'const' type.
>
You're right. Initialization the way I suggested only works when
everything is in the same source file. That's a pity. So we can
either manage it they way you've done here or the way you did
in a previous patch, which was to include the info array in each
source file by putting it in the header. I think I prefer the
approach you used in this version more though.
Thanks,
drew
next prev parent reply other threads:[~2023-06-24 7:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:56 [PATCH v3 00/19] target/riscv, KVM: fixes and enhancements Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 01/19] target/riscv: skip features setup for KVM CPUs Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 02/19] hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 03/19] target/riscv/cpu.c: restrict 'mvendorid' value Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 04/19] target/riscv/cpu.c: restrict 'mimpid' value Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 05/19] target/riscv/cpu.c: restrict 'marchid' value Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 06/19] target/riscv: use KVM scratch CPUs to init KVM properties Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 07/19] target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids() Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 08/19] target/riscv: handle mvendorid/marchid/mimpid for KVM CPUs Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 09/19] linux-headers: Update to v6.4-rc1 Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 10/19] target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 11/19] target/riscv/cpu: add misa_ext_info_arr[] Daniel Henrique Barboza
2023-06-23 9:30 ` Andrew Jones
2023-06-22 13:56 ` [PATCH v3 12/19] target/riscv: add KVM specific MISA properties Daniel Henrique Barboza
2023-06-23 9:38 ` Andrew Jones
2023-06-23 14:14 ` Daniel Henrique Barboza
2023-06-24 7:32 ` Andrew Jones [this message]
2023-06-25 22:38 ` Daniel Henrique Barboza
2023-06-26 6:24 ` Andrew Jones
2023-06-22 13:56 ` [PATCH v3 13/19] target/riscv/kvm.c: update KVM MISA bits Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 14/19] target/riscv/kvm.c: add multi-letter extension KVM properties Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 15/19] target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext() Daniel Henrique Barboza
2023-06-23 9:46 ` Andrew Jones
2023-06-22 13:56 ` [PATCH v3 16/19] target/riscv/cpu.c: create KVM mock properties Daniel Henrique Barboza
2023-06-23 9:58 ` Andrew Jones
2023-06-23 14:28 ` Daniel Henrique Barboza
2023-06-24 7:41 ` Andrew Jones
2023-06-26 17:27 ` Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 17/19] target/riscv: update multi-letter extension KVM properties Daniel Henrique Barboza
2023-06-22 13:56 ` [PATCH v3 18/19] target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper Daniel Henrique Barboza
2023-06-22 13:57 ` [PATCH v3 19/19] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230624-bd82bafb08e5daa8fb81b72f@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).