qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <anisinha@redhat.com>
Cc: qemu-devel@nongnu.org, imammedo@redhat.com, jusual@redhat.com,
	thuth@redhat.com, lvivier@redhat.com,
	michael.labiuk@virtuozzo.com
Subject: Re: [PATCH v4 0/5] test and QEMU fixes to ensure proper PCIE device usage
Date: Mon, 26 Jun 2023 09:54:57 -0400	[thread overview]
Message-ID: <20230626095407-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230626135324.10687-1-anisinha@redhat.com>

Ani, two versions a day is too much, pls don't unless first one
has been sent by mistake or something. then explain what
it was pls.

On Mon, Jun 26, 2023 at 07:23:19PM +0530, Ani Sinha wrote:
> Patches 1-4:
> Fix tests so that devices do not use non-zero slots on the pcie root
> ports. PCIE ports only have one slot, so PCIE devices can only be
> plugged into slot 0 on a PCIE port.
> 
> Patch 5:
> Enforce only one slot on PCIE port.
> 
> The test fixes must be applied before the QEMU change that checks for use
> of a single slot in PCIE port.
> 
> CC: mst@redhat.com
> CC: imammedo@redhat.com
> CC: jusual@redhat.com
> CC: thuth@redhat.com
> CC: lvivier@redhat.com
> CC: michael.labiuk@virtuozzo.com
> 
> Changelog:
> v4: reword commit log for patch 4.
> v3: tags added. reword the error description in patch 5. Reword commit log in patch 4. 
> v2: add hd-geo-test fix as well as the actual QEMU code fix to the patchset.
> The patches are added in the right order.
> 
> Ani Sinha (5):
>   tests/acpi: allow changes in DSDT.noacpihp table blob
>   tests/acpi/bios-tables-test: use the correct slot on the
>     pcie-root-port
>   tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp
>   tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and
>     simplify test
>   hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port
> 
>  hw/pci/pci.c                      |   6 ++++++
>  tests/data/acpi/q35/DSDT.noacpihp | Bin 8248 -> 8241 bytes
>  tests/qtest/bios-tables-test.c    |   4 ++--
>  tests/qtest/hd-geo-test.c         |  18 ++++++++----------
>  4 files changed, 16 insertions(+), 12 deletions(-)
> 
> -- 
> 2.39.1



  parent reply	other threads:[~2023-06-26 13:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 13:53 [PATCH v4 0/5] test and QEMU fixes to ensure proper PCIE device usage Ani Sinha
2023-06-26 13:53 ` [PATCH v4 1/5] tests/acpi: allow changes in DSDT.noacpihp table blob Ani Sinha
2023-06-26 13:53 ` [PATCH v4 2/5] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port Ani Sinha
2023-06-26 13:53 ` [PATCH v4 3/5] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp Ani Sinha
2023-06-26 13:53 ` [PATCH v4 4/5] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test Ani Sinha
2023-06-26 14:22   ` Igor Mammedov
2023-06-26 16:03     ` Ani Sinha
2023-06-26 13:53 ` [PATCH v4 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port Ani Sinha
2023-06-26 13:54 ` Michael S. Tsirkin [this message]
2023-06-26 13:56   ` [PATCH v4 0/5] test and QEMU fixes to ensure proper PCIE device usage Ani Sinha
2023-06-26 13:59     ` Ani Sinha
2023-06-26 15:35       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230626095407-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jusual@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=michael.labiuk@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).