qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Ani Sinha <anisinha@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port
Date: Mon, 26 Jun 2023 13:02:11 +0200	[thread overview]
Message-ID: <20230626130211.32fa2659@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20230621140723.462220-3-anisinha@redhat.com>

On Wed, 21 Jun 2023 19:37:22 +0530
Ani Sinha <anisinha@redhat.com> wrote:

> PCIE ports only have one slot, slot 0. Hence, non-zero slots are not available
> for PCIE devices on PCIE root ports. Fix test_acpi_q35_tcg_no_acpi_hotplug()
> so that the test does not use them.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index ed1c69cf01..47ba20b957 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1020,9 +1020,9 @@ static void test_acpi_q35_tcg_no_acpi_hotplug(void)
>          " -device pci-testdev,bus=nohprp,acpi-index=501"
>          " -device pcie-root-port,id=nohprpint,port=0x0,chassis=3,hotplug=off,"
>                                   "multifunction=on,addr=8.0"
> -        " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=8.1"
> +        " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=0.1"
>          " -device pcie-root-port,id=hprp2,port=0x0,chassis=4,bus=nohprpint,"
> -                                 "addr=9.0"
> +                                 "addr=0.2"
>          " -device pci-testdev,bus=hprp2,acpi-index=602"
>          , &data);
>      free_test_data(&data);



  reply	other threads:[~2023-06-26 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 14:07 [PATCH 0/3] fix bios-tables-test Ani Sinha
2023-06-21 14:07 ` [PATCH 1/3] tests/acpi: allow changes in DSDT.noacpihp table blob Ani Sinha
2023-06-26 11:02   ` Igor Mammedov
2023-06-21 14:07 ` [PATCH 2/3] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port Ani Sinha
2023-06-26 11:02   ` Igor Mammedov [this message]
2023-06-21 14:07 ` [PATCH 3/3] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp Ani Sinha
2023-06-26 11:09   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230626130211.32fa2659@imammedo.users.ipa.redhat.com \
    --to=imammedo@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).