qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	mrezanin@redhat.com, "Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 0/4] pc-bios/s390-ccw: Fixes and improvements for start.S
Date: Mon, 26 Jun 2023 15:21:34 +0200	[thread overview]
Message-ID: <20230626132138.87668-1-thuth@redhat.com> (raw)

Main motivation of this series was a bug that showed up when compiling
with Clang 16 and binutils 2.40 (which has been reported in Fedora ELN, see
https://bugzilla.redhat.com/show_bug.cgi?id=2216662). This is fixed in
the fourth patch.

While working on this issue, I came accross some other issues which I
address in the first three patches:

- Indentation is a mixture between tabs and spaces in start.S (patch 1)
- We do not set up a stack frame for the main() function, which could
  cause memory corruption (patch 2)
- The stack is declared in multiple places, though it's only needed
  in start.S (patch 3)

Thomas Huth (4):
  pc-bios/s390-ccw: Fix indentation in start.S
  pc-bios/s390-ccw: Provide space for initial stack frame in start.S
  pc-bios/s390-ccw: Move the stack array into start.S
  pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction

 pc-bios/s390-ccw/s390-ccw.h |   1 -
 pc-bios/s390-ccw/main.c     |   1 -
 pc-bios/s390-ccw/netmain.c  |   1 -
 pc-bios/s390-ccw/start.S    | 143 +++++++++++++++++++-----------------
 4 files changed, 75 insertions(+), 71 deletions(-)

-- 
2.39.3



             reply	other threads:[~2023-06-26 13:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26 13:21 Thomas Huth [this message]
2023-06-26 13:21 ` [PATCH 1/4] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-26 13:40   ` Cédric Le Goater
2023-06-26 13:21 ` [PATCH 2/4] pc-bios/s390-ccw: Provide space for initial stack frame " Thomas Huth
2023-06-26 13:41   ` Cédric Le Goater
2023-06-26 14:46   ` Christian Borntraeger
2023-06-26 13:21 ` [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-26 14:54   ` Christian Borntraeger
2023-06-26 15:25     ` Richard Henderson
2023-06-27  6:55       ` Thomas Huth
2023-06-26 13:21 ` [PATCH 4/4] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230626132138.87668-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=mrezanin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).