From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
mrezanin@redhat.com, "Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 4/4] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction
Date: Mon, 26 Jun 2023 15:21:38 +0200 [thread overview]
Message-ID: <20230626132138.87668-5-thuth@redhat.com> (raw)
In-Reply-To: <20230626132138.87668-1-thuth@redhat.com>
start.S currently cannot be compiled with Clang 16 and binutils 2.40:
ld: start.o(.text+0x8): misaligned symbol `__bss_start' (0xc1e5) for
relocation R_390_PC32DBL
According to the built-in linker script of ld, the symbol __bss_start
can actually point *before* the .bss section and does not need to have
any alignment, so in certain situations (like when using the internal
assembler of Clang), the __bss_start symbol can indeed be unaligned
and thus it is not suitable for being used with the "larl" instruction
that needs an address that is at least aligned to halfwords.
The problem went unnoticed so far since binutils <= 2.39 did not
check the alignment, but starting with binutils 2.40, such unaligned
addresses are now refused.
Fix it by using the real start address of the .bss section instead.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2216662
Reported-by: Miroslav Rezanina <mrezanin@redhat.com>
Suggested-by: Nick Clifton <nickc@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/start.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index 47ef6e8aa8..6747d4c600 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -18,7 +18,7 @@ _start:
larl %r15,stack + STACK_SIZE - 160 /* Set up stack */
/* clear bss */
- larl %r2,__bss_start
+ larl %r2,.bss
larl %r3,_end
slgr %r3,%r2 /* get sizeof bss */
ltgr %r3,%r3 /* bss empty? */
--
2.39.3
prev parent reply other threads:[~2023-06-26 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 13:21 [PATCH 0/4] pc-bios/s390-ccw: Fixes and improvements for start.S Thomas Huth
2023-06-26 13:21 ` [PATCH 1/4] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-26 13:40 ` Cédric Le Goater
2023-06-26 13:21 ` [PATCH 2/4] pc-bios/s390-ccw: Provide space for initial stack frame " Thomas Huth
2023-06-26 13:41 ` Cédric Le Goater
2023-06-26 14:46 ` Christian Borntraeger
2023-06-26 13:21 ` [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-26 14:54 ` Christian Borntraeger
2023-06-26 15:25 ` Richard Henderson
2023-06-27 6:55 ` Thomas Huth
2023-06-26 13:21 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626132138.87668-5-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@kaod.org \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).