* [PATCH] target/ppc: Only generate decodetree files when TCG is enabled
@ 2023-06-26 14:01 Philippe Mathieu-Daudé
2023-06-27 12:01 ` Greg Kurz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-26 14:01 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-ppc, Cédric Le Goater, David Gibson,
Daniel Henrique Barboza, Greg Kurz, Thomas Huth, Nicholas Piggin,
Philippe Mathieu-Daudé
No need to generate TCG-specific decodetree files
when TCG is disabled.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/ppc/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/meson.build b/target/ppc/meson.build
index a69f174f41..4c2635039e 100644
--- a/target/ppc/meson.build
+++ b/target/ppc/meson.build
@@ -28,7 +28,7 @@ gen = [
extra_args: ['--static-decode=decode_insn64',
'--insnwidth=64']),
]
-ppc_ss.add(gen)
+ppc_ss.add(when: 'CONFIG_TCG', if_true: gen)
ppc_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
ppc_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user_only_helper.c'))
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] target/ppc: Only generate decodetree files when TCG is enabled
2023-06-26 14:01 [PATCH] target/ppc: Only generate decodetree files when TCG is enabled Philippe Mathieu-Daudé
@ 2023-06-27 12:01 ` Greg Kurz
2023-06-28 7:46 ` Richard Henderson
2023-06-30 16:45 ` Daniel Henrique Barboza
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kurz @ 2023-06-27 12:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, qemu-ppc, Cédric Le Goater, David Gibson,
Daniel Henrique Barboza, Thomas Huth, Nicholas Piggin
On Mon, 26 Jun 2023 16:01:00 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> No need to generate TCG-specific decodetree files
> when TCG is disabled.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> target/ppc/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/meson.build b/target/ppc/meson.build
> index a69f174f41..4c2635039e 100644
> --- a/target/ppc/meson.build
> +++ b/target/ppc/meson.build
> @@ -28,7 +28,7 @@ gen = [
> extra_args: ['--static-decode=decode_insn64',
> '--insnwidth=64']),
> ]
> -ppc_ss.add(gen)
> +ppc_ss.add(when: 'CONFIG_TCG', if_true: gen)
>
> ppc_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
> ppc_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user_only_helper.c'))
--
Greg
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/ppc: Only generate decodetree files when TCG is enabled
2023-06-26 14:01 [PATCH] target/ppc: Only generate decodetree files when TCG is enabled Philippe Mathieu-Daudé
2023-06-27 12:01 ` Greg Kurz
@ 2023-06-28 7:46 ` Richard Henderson
2023-06-30 16:45 ` Daniel Henrique Barboza
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-06-28 7:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-ppc, Cédric Le Goater, David Gibson,
Daniel Henrique Barboza, Greg Kurz, Thomas Huth, Nicholas Piggin
On 6/26/23 16:01, Philippe Mathieu-Daudé wrote:
> No need to generate TCG-specific decodetree files
> when TCG is disabled.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/ppc/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/ppc: Only generate decodetree files when TCG is enabled
2023-06-26 14:01 [PATCH] target/ppc: Only generate decodetree files when TCG is enabled Philippe Mathieu-Daudé
2023-06-27 12:01 ` Greg Kurz
2023-06-28 7:46 ` Richard Henderson
@ 2023-06-30 16:45 ` Daniel Henrique Barboza
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Henrique Barboza @ 2023-06-30 16:45 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-ppc, Cédric Le Goater, David Gibson, Greg Kurz,
Thomas Huth, Nicholas Piggin
On 6/26/23 11:01, Philippe Mathieu-Daudé wrote:
> No need to generate TCG-specific decodetree files
> when TCG is disabled.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
Daniel
> target/ppc/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/meson.build b/target/ppc/meson.build
> index a69f174f41..4c2635039e 100644
> --- a/target/ppc/meson.build
> +++ b/target/ppc/meson.build
> @@ -28,7 +28,7 @@ gen = [
> extra_args: ['--static-decode=decode_insn64',
> '--insnwidth=64']),
> ]
> -ppc_ss.add(gen)
> +ppc_ss.add(when: 'CONFIG_TCG', if_true: gen)
>
> ppc_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
> ppc_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user_only_helper.c'))
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-30 16:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-26 14:01 [PATCH] target/ppc: Only generate decodetree files when TCG is enabled Philippe Mathieu-Daudé
2023-06-27 12:01 ` Greg Kurz
2023-06-28 7:46 ` Richard Henderson
2023-06-30 16:45 ` Daniel Henrique Barboza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).